Bug 233513 – GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code

• Component: WebGL
• Status: RESOLVED FIXED

[Kimmo Kinnunen]

GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code

This blocks the task of removing ifdefs from GraphicsContextGLOpenGL.h by means of separating various code paths to separate classes.

GraphicsContextGLOpenGL.cpp should contain only "OpenGL" specific code. Currently that code lives in GraphicsContextGLOpenGLCommon.cpp, so GraphicsContextGLOpenGL.cpp should be made empty and then ultimately GraphicsContextGLOpenGLCommon.cpp would be renamed to GraphicsContextGLOpenGL.cpp

ANGLE specific code should go into GraphicsContextGLANGLE.cpp

Platform specific code should go into platform specific files such as GraphicsContextGLCocoa.cpp and compositor specific files such as GraphicsContextGLTextureMapper.cpp.

[Kimmo Kinnunen]

Created attachment 445172 [details]
Patch

[Kimmo Kinnunen]

Created attachment 445173 [details]
Patch

[Kimmo Kinnunen]

Created attachment 445176 [details]
Patch

[Kimmo Kinnunen]

Created attachment 445178 [details]
Patch

[Antti Koivisto]

Comment on attachment 445178 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445178&action=review

> Source/WebCore/platform/graphics/opengl/GraphicsContextGLOpenGL.cpp:-67
> -void GraphicsContextGLOpenGL::resetBuffersToAutoClear()
> -{
> -    GCGLuint buffers = GraphicsContextGL::COLOR_BUFFER_BIT;
> -    // The GraphicsContextGL's attributes (as opposed to
> -    // WebGLRenderingContext's) indicate whether there is an
> -    // implicitly-allocated stencil buffer, for example.
> -    auto attrs = contextAttributes();
> -    if (attrs.depth)
> -        buffers |= GraphicsContextGL::DEPTH_BUFFER_BIT;
> -    if (attrs.stencil)
> -        buffers |= GraphicsContextGL::STENCIL_BUFFER_BIT;
> -    setBuffersToAutoClear(buffers);
> -}
> -

Might want to comment what happened to this function  (and others?) since it doesn't move anywhere mechanically.

[EWS]

Committed r286175 (244558@main): <https://commits.webkit.org/244558@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445178 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85764264>

[Kimmo Kinnunen]

*** Bug 233512 has been marked as a duplicate of this bug. ***