Bug 233512

Summary:	GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code
Product:	WebKit	Reporter:	Kimmo Kinnunen <kkinnunen>
Component:	WebGL	Assignee:	Nobody <webkit-unassigned>
Status:	RESOLVED DUPLICATE
Severity:	Normal	CC:	dino, kbr, kkinnunen
Priority:	P2
Version:	WebKit Local Build
Hardware:	Unspecified
OS:	Unspecified
Bug Depends on:
Bug Blocks:	221664

Description Kimmo Kinnunen 2021-11-25 23:16:05 PST

GraphicsContextGLOpenGL.cpp contains OpenGL implementation specific and platform specific code

This blocks the task of removing ifdefs from GraphicsContextGLOpenGL.h by means of separating various code paths to separate classes.

GraphicsContextGLOpenGL.cpp should contain only "OpenGL" specific code. Currently that code lives in GraphicsContextGLOpenGLCommon.cpp, so GraphicsContextGLOpenGL.cpp should be made empty and then ultimately GraphicsContextGLOpenGLCommon.cpp would be renamed to GraphicsContextGLOpenGL.cpp

ANGLE specific code should go into GraphicsContextGLANGLE.cpp

Platform specific code should go into platform specific files such as GraphicsContextGLCocoa.cpp and compositor specific files such as GraphicsContextGLTextureMapper.cpp.

Comment 1 Kimmo Kinnunen 2021-11-26 06:36:13 PST


*** This bug has been marked as a duplicate of bug 233513 ***