Bug 23350

Summary: Build failure because of missing include in wtf/ThreadingPthreads.cpp
Product: WebKit Reporter: Gustavo Noronha (kov) <gustavo>
Component: JavaScriptCoreAssignee: Gustavo Noronha (kov) <gustavo>
Status: RESOLVED DUPLICATE    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: PC   
OS: All   
Attachments:
Description Flags
proposed fix none

Gustavo Noronha (kov)
Reported 2009-01-15 09:11:49 PST
Revision 39908 adds usage of INT_MAX and other limits to threading implementations, but missed the limits.h include for the pthreads implementation.
Attachments
proposed fix (1.32 KB, patch)
2009-01-15 09:14 PST, Gustavo Noronha (kov) 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Gustavo Noronha (kov)
Comment 1 2009-01-15 09:14:02 PST
Created attachment 26760 [details] proposed fix
Brent Fulgham
Comment 2 2009-01-15 10:01:51 PST
> #include <errno.h> > #include <sys/time.h> > +#include <limits.h> We generally put the includes in ASCII order.
Darin Adler
Comment 3 2009-01-15 10:29:28 PST
*** This bug has been marked as a duplicate of 23347 ***
Darin Adler
Comment 4 2009-01-15 10:29:57 PST
Comment on attachment 26760 [details] proposed fix Patch is fine, but there's already a reviewed patch in the other bug.
Note You need to log in before you can comment on or make changes to this bug.