Bug 233491

Summary: GraphicsContextGL implementations should have separate class declarations
Product: WebKit Reporter: Kimmo Kinnunen <kkinnunen>
Component: WebGLAssignee: Kimmo Kinnunen <kkinnunen>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, cmarcelo, dino, ews-watchlist, gyuyoung.kim, Hironori.Fujii, kbr, kkinnunen, koivisto, kondapallykalyan, luiz, ryuan.choi, sergio, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 221664    
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch none

Description Kimmo Kinnunen 2021-11-25 03:29:54 PST 
GraphicsContextGL implementations should have separate class definitions 
The extensive use of #ifdef and unmaintained code make the Cocoa variant hard to develop.
Comment 1 Kimmo Kinnunen 2021-11-25 03:38:39 PST 
Created attachment 445132 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-11-25 03:45:19 PST 
Created attachment 445133 [details]
Patch
Comment 3 Antti Koivisto 2021-11-25 05:08:04 PST 
Comment on attachment 445133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445133&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:223
> +// FIXME: Below is functionality that should be moved to GraphicsContextGLCocoa to simplify the base class.
> +
> +GraphicsContextGLOpenGL::GraphicsContextGLOpenGL(GraphicsContextGLAttributes attrs)

Hopefully soonish!
Comment 4 EWS 2021-11-25 05:22:49 PST 
Committed r286167 (244550@main): <https://commits.webkit.org/244550@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445133 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-25 05:23:26 PST 
<rdar://problem/85749766>