Bug 233491 - GraphicsContextGL implementations should have separate class declarations
Summary: GraphicsContextGL implementations should have separate class declarations
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebGL (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Kimmo Kinnunen
URL:
Keywords: InRadar
Depends on:
Blocks: gcgranglecleanup
  Show dependency tree / graph
 
Reported: 2021-11-25 03:29 PST by Kimmo Kinnunen
Modified: 2021-11-25 05:23 PST (History)
14 users (show)

See Also:

Attachments
Patch (138.77 KB, patch)
2021-11-25 03:38 PST, Kimmo Kinnunen 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (139.15 KB, patch)
2021-11-25 03:45 PST, Kimmo Kinnunen 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kimmo Kinnunen 2021-11-25 03:29:54 PST 
GraphicsContextGL implementations should have separate class definitions 
The extensive use of #ifdef and unmaintained code make the Cocoa variant hard to develop.
Comment 1 Kimmo Kinnunen 2021-11-25 03:38:39 PST 
Created attachment 445132 [details]
Patch
Comment 2 Kimmo Kinnunen 2021-11-25 03:45:19 PST 
Created attachment 445133 [details]
Patch
Comment 3 Antti Koivisto 2021-11-25 05:08:04 PST 
Comment on attachment 445133 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445133&action=review

> Source/WebCore/platform/graphics/cocoa/GraphicsContextGLCocoa.mm:223
> +// FIXME: Below is functionality that should be moved to GraphicsContextGLCocoa to simplify the base class.
> +
> +GraphicsContextGLOpenGL::GraphicsContextGLOpenGL(GraphicsContextGLAttributes attrs)

Hopefully soonish!
Comment 4 EWS 2021-11-25 05:22:49 PST 
Committed r286167 (244550@main): <https://commits.webkit.org/244550@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445133 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-25 05:23:26 PST 
<rdar://problem/85749766>