Summary: | Make webpushd "fake registration for testing" much more complicated by adding a "mock app bundle" install | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||||||
Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||||||
Status: | RESOLVED FIXED | ||||||||||||||||
Severity: | Normal | CC: | achristensen, thorton, webkit-bug-importer | ||||||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||||||
Version: | WebKit Nightly Build | ||||||||||||||||
Hardware: | Unspecified | ||||||||||||||||
OS: | Unspecified | ||||||||||||||||
Attachments: |
|
Description
Brady Eidson
2021-11-23 15:29:39 PST
Created attachment 445104 [details]
EWS v1
Created attachment 445108 [details]
EWS v2
Created attachment 445112 [details]
EWS v3
Created attachment 445115 [details]
EWS v4
Comment on attachment 445115 [details] EWS v4 View in context: https://bugs.webkit.org/attachment.cgi?id=445115&action=review > Source/WebKit/webpushd/AppBundleRequest.h:55 > + ClientConnection* m_connection; Let's not store a raw pointer. Can this be a WeakPtr? > Source/WebKit/webpushd/MockAppBundleForTesting.mm:43 > + extra space, could use =default; > Source/WebKit/webpushd/PushAppBundle.h:34 > +enum class PushAppBundleExists { : bool > Source/WebKit/webpushd/PushAppBundle.h:39 > +enum class PushAppBundleCreationResult { : bool Created attachment 445303 [details]
PFL v1
Created attachment 445312 [details]
PFL v2
Committed r286273 (244634@main): <https://commits.webkit.org/244634@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 445312 [details]. |