Bug 233452

Summary: [GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
Product: WebKit Reporter: Lauro Moura <lmoura>
Component: WebKitGTKAssignee: Lauro Moura <lmoura>
Status: RESOLVED FIXED    
Severity: Normal CC: bugs-noreply, mcatanzaro
Priority: P2    
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 210100    
Attachments:
Description Flags
Patch
none
Patch for landing none

Description Lauro Moura 2021-11-23 14:56:35 PST 
[GTK] GdkRGBA expects colors to be in the 0.0 to 1.0 range
Comment 1 Lauro Moura 2021-11-23 14:57:32 PST 
Created attachment 445051 [details]
Patch
Comment 2 Michael Catanzaro 2021-11-23 15:50:47 PST 
Comment on attachment 445051 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445051&action=review

> Tools/MiniBrowser/gtk/BrowserWindow.c:1336
>      window->backgroundColor.alpha = 1;

Nit: might as well write this as 1.0 as well, to be consistent with the line above. Or write 1 in both places. Doesn't matter, of course....
Comment 3 Lauro Moura 2021-11-23 19:17:53 PST 
Created attachment 445058 [details]
Patch for landing
Comment 4 EWS 2021-11-23 19:47:13 PST 
Committed r286141 (244528@main): <https://commits.webkit.org/244528@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445058 [details].