Bug 23345

Summary: SharedBuffer.h should include wtf/OwnPtr.h
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
none
v2 patch eric: review+

Darin Fisher (:fishd, Google)
Reported 2009-01-15 01:15:01 PST
SharedBuffer.h should include wtf/OwnPtr.h ... because it has an OwnPtr<T> member variable. As is, any .cpp file that includes SharedBuffer.h has to include OwnPtr.h. That seems undesirable. Patch coming up.
Attachments
v1 patch (913 bytes, patch)
2009-01-15 01:16 PST, Darin Fisher (:fishd, Google) 		no flags
DetailsFormatted DiffDiff
v2 patch (968 bytes, patch)
2009-01-15 01:17 PST, Darin Fisher (:fishd, Google) 		eric: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Darin Fisher (:fishd, Google)
Comment 1 2009-01-15 01:16:13 PST
Created attachment 26750 [details] v1 patch
Darin Fisher (:fishd, Google)
Comment 2 2009-01-15 01:17:39 PST
Created attachment 26751 [details] v2 patch ... and sort the includes.
Eric Seidel (no email)
Comment 3 2009-01-15 01:19:37 PST
Comment on attachment 26751 [details] v2 patch LGTM.
Darin Fisher (:fishd, Google)
Comment 4 2009-01-15 01:28:14 PST
http://trac.webkit.org/changeset/39933
Note You need to log in before you can comment on or make changes to this bug.