Bug 23345

Summary: SharedBuffer.h should include wtf/OwnPtr.h
Product: WebKit Reporter: Darin Fisher (:fishd, Google) <fishd>
Component: PlatformAssignee: Darin Fisher (:fishd, Google) <fishd>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: All   
Attachments:
Description Flags
v1 patch
none
v2 patch eric: review+

Description Darin Fisher (:fishd, Google) 2009-01-15 01:15:01 PST 
SharedBuffer.h should include wtf/OwnPtr.h

... because it has an OwnPtr<T> member variable.

As is, any .cpp file that includes SharedBuffer.h has to include OwnPtr.h.  That seems undesirable.

Patch coming up.
Comment 1 Darin Fisher (:fishd, Google) 2009-01-15 01:16:13 PST 
Created attachment 26750 [details]
v1 patch
Comment 2 Darin Fisher (:fishd, Google) 2009-01-15 01:17:39 PST 
Created attachment 26751 [details]
v2 patch

... and sort the includes.
Comment 3 Eric Seidel (no email) 2009-01-15 01:19:37 PST 
Comment on attachment 26751 [details]
v2 patch

LGTM.
Comment 4 Darin Fisher (:fishd, Google) 2009-01-15 01:28:14 PST 
http://trac.webkit.org/changeset/39933