Bug 233424

Summary: [JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Product: WebKit Reporter: Geza Lore <glore>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, keith_miller, mark.lam, msaboff, saam, tzagallo, webkit-bug-importer, xan.lopez, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch
none
Fix nit none

Description Geza Lore 2021-11-22 07:28:02 PST 
[JSC] Unify most Baseline ops between JSVALUE64 and JSVALUE32_64
Comment 1 Geza Lore 2021-11-22 08:26:11 PST 
Created attachment 444968 [details]
Patch
Comment 2 Geza Lore 2021-11-22 09:51:49 PST 
Created attachment 444975 [details]
Patch
Comment 3 Geza Lore 2021-11-23 02:16:32 PST 
Created attachment 445019 [details]
Patch
Comment 4 Geza Lore 2021-11-24 05:51:29 PST 
Created attachment 445093 [details]
Patch
Comment 5 Radar WebKit Bug Importer 2021-11-29 07:28:19 PST 
<rdar://problem/85815818>
Comment 6 Yusuke Suzuki 2021-11-29 13:00:43 PST 
Comment on attachment 445093 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=445093&action=review

r=me

> Source/JavaScriptCore/jit/JIT.h:336
> +        static inline constexpr bool is_profiled_op = std::is_same_v<decltype(Op::Metadata::m_profile), ValueProfile>;

Rename it to isProfiledOp.
Comment 7 Geza Lore 2021-11-30 02:40:48 PST 
Created attachment 445401 [details]
Fix nit
Comment 8 EWS 2021-11-30 07:44:33 PST 
Committed r286296 (244655@main): <https://commits.webkit.org/244655@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 445401 [details].