Bug 233423

Summary: [LFC][Integration] Remove dirOverride
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: Layout and RenderingAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, changseok, dino, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, kondapallykalyan, mmaxfield, pdr, sabouhallawa, schenney, sergio, simon.fraser, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch for landing none

Antti Koivisto
Reported 2021-11-22 07:26:16 PST
This legacy inline box bit is used to set directionOverride bit when creating a TextRun for the box. However that bit is never needed in cases these TextRuns are created for (painting and editing). In practice it only affects render tree dumps and can be removed.
Attachments
Patch (11.76 KB, patch)
2021-11-22 07:29 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (1.16 MB, patch)
2021-11-22 08:19 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch for landing (1.16 MB, patch)
2021-11-22 09:20 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-11-22 07:29:49 PST
Created attachment 444965 [details] Patch
Antti Koivisto
Comment 2 2021-11-22 08:19:51 PST
Created attachment 444967 [details] Patch
Antti Koivisto
Comment 3 2021-11-22 09:20:01 PST
Created attachment 444972 [details] Patch for landing
EWS
Comment 4 2021-11-22 10:13:17 PST
Committed r286113 (244500@main): <https://commits.webkit.org/244500@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444972 [details].
Radar WebKit Bug Importer
Comment 5 2021-11-22 10:14:21 PST
<rdar://problem/85679362>
Note You need to log in before you can comment on or make changes to this bug.