| Summary: | Allow AudioSampleDataSource to increase/decrease buffered data progressively | ||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | youenn fablet <youennf> | ||||||||||||
| Component: | WebRTC | Assignee: | youenn fablet <youennf> | ||||||||||||
| Status: | RESOLVED FIXED | ||||||||||||||
| Severity: | Normal | CC: | eric.carlson, ews-watchlist, glenn, hta, jer.noble, philipj, sergio, tommyw, webkit-bug-importer, youennf | ||||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||||
| Version: | WebKit Nightly Build | ||||||||||||||
| Hardware: | Unspecified | ||||||||||||||
| OS: | Unspecified | ||||||||||||||
| Attachments: |
|
||||||||||||||
|
Description
youenn fablet
2021-11-22 06:54:06 PST
Created attachment 444964 [details]
Patch
Comment on attachment 444964 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444964&action=review r=me > Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm:85 > + if (m_lowConverter) { > + PAL::AudioConverterDispose(m_lowConverter); > + m_lowConverter = nullptr; > + } Nit: It might be worth creating a simple AudioConverter class to handle allocation, deallocation, and setup so you can cut down on the amount of boiler plate in the destructor and here. Created attachment 445544 [details]
Patch
Created attachment 447239 [details]
Rebasing
Comment on attachment 447239 [details] Rebasing View in context: https://bugs.webkit.org/attachment.cgi?id=447239&action=review > Source/WebCore/platform/audio/cocoa/AudioSampleDataConverter.mm:87 > + return 0; s/0/noErr/ > Source/WebCore/platform/audio/cocoa/AudioSampleDataSource.mm:93 > + return 0; Ditto Created attachment 447351 [details]
Updated according review
Created attachment 447357 [details]
Use > instead of == when comparing sample count
Committed r287157 (245334@main): <https://commits.webkit.org/245334@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 447357 [details]. |