Bug 233411

Summary: Unused getEOTHeader method in OpenTypeUtilities.cpp
Product: WebKit Reporter: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Component: Layout and RenderingAssignee: Jean-Yves Avenard [:jya] <jean-yves.avenard>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, simon.fraser, webkit-bug-importer, youennf, zalan
Priority: P2 Keywords: InRadar
Version: Other   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 233030    
Attachments:
Description Flags
Patch
none
Patch none

Jean-Yves Avenard [:jya]
Reported 2021-11-21 21:17:42 PST
The method `bool getEOTHeader(SharedBuffer* fontData, EOTHeader& eotHeader, size_t& overlayDst, size_t& overlaySrc, size_t& overlayLength)` is unused in the code
Attachments
Patch (8.63 KB, patch)
2021-11-21 21:21 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Patch (8.66 KB, patch)
2021-11-21 21:25 PST, Jean-Yves Avenard [:jya] 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-21 21:18:17 PST
<rdar://problem/85656827>
Jean-Yves Avenard [:jya]
Comment 2 2021-11-21 21:21:51 PST
Created attachment 444938 [details] Patch
Jean-Yves Avenard [:jya]
Comment 3 2021-11-21 21:25:32 PST
Created attachment 444939 [details] Patch
Jean-Yves Avenard [:jya]
Comment 4 2021-11-21 21:39:50 PST
To add: getEOTHeader requires a flattened SharedBuffer ; this code appears ancient, the symbol isn't exported and would require modification following bug 233030 which would make any customers incompatible anyway.
EWS
Comment 5 2021-11-22 12:35:13 PST
Committed r286117 (244504@main): <https://commits.webkit.org/244504@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444939 [details].
Note You need to log in before you can comment on or make changes to this bug.