Bug 233407

Summary: [Model] clean up compile-time flags and condition IDL methods behind them
Product: WebKit Reporter: Antoine Quint <graouts>
Component: New BugsAssignee: Antoine Quint <graouts>
Status: REOPENED    
Severity: Normal CC: benjamin, cdumez, cmarcelo, commit-queue, dino, esprehn+autocc, ews-watchlist, kondapallykalyan, thorton, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on: 233652    
Bug Blocks:    
Attachments:
Description Flags
Patch
none
Patch thorton: review+

Antoine Quint
Reported 2021-11-21 03:09:53 PST
The various compile-time flags are not well organized and their use throughout the code related to <model> is a bit messy and lacking with regards to IDL method definitions.
Attachments
Patch (73.89 KB, patch)
2021-11-21 03:12 PST, Antoine Quint 		no flags
DetailsFormatted DiffDiff
Patch (58.47 KB, patch)
2021-11-24 00:29 PST, Antoine Quint 		thorton: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2021-11-21 03:12:31 PST
Created attachment 444923 [details] Patch
Tim Horton
Comment 2 2021-11-21 14:03:46 PST
r- because it seems like this entirely regresses https://trac.webkit.org/changeset/282567/webkit; I'll retract my r- if you build with SEPARATED_MODEL on and everything works.
Antoine Quint
Comment 3 2021-11-24 00:29:52 PST
Created attachment 445077 [details] Patch
Antoine Quint
Comment 4 2021-11-24 00:30:20 PST
(In reply to Tim Horton from comment #2) > r- because it seems like this entirely regresses > https://trac.webkit.org/changeset/282567/webkit; I'll retract my r- if you > build with SEPARATED_MODEL on and everything works. The new patch retains ENABLE_ARKIT_INLINE_PREVIEW accounting for the changes made in r 282567.
Radar WebKit Bug Importer
Comment 5 2021-11-28 03:10:20 PST
<rdar://problem/85786210>
Tim Horton
Comment 6 2021-11-29 10:40:35 PST
Comment on attachment 445077 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=445077&action=review > Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:58 > -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS) > +#if HAVE(ASV_INLINE_PREVIEW_IOS) Should just remove this ifdef, it's a lie > Source/WebCore/PAL/pal/spi/cocoa/QuartzCoreSPI.h:95 > -#if ENABLE(ARKIT_INLINE_PREVIEW_IOS) > +#if HAVE(ASV_INLINE_PREVIEW_IOS) Should just remove this ifdef, it's a lie
Antoine Quint
Comment 7 2021-11-29 11:06:48 PST
Committed r286227 (244608@main): <https://commits.webkit.org/244608@main>
WebKit Commit Bot
Comment 8 2021-11-30 12:05:09 PST
Re-opened since this is blocked by bug 233652
Note You need to log in before you can comment on or make changes to this bug.