| Summary: | [Model] add audio support | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Antoine Quint <graouts> | ||||
| Component: | New Bugs | Assignee: | Antoine Quint <graouts> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | benjamin, cdumez, cmarcelo, esprehn+autocc, ews-watchlist, kondapallykalyan, thorton, webkit-bug-importer, wenson_hsieh | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Antoine Quint
2021-11-19 07:13:48 PST
Created attachment 444817 [details]
Patch
Comment on attachment 444817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160 > + auto* strongPage = m_page.get(); This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't call it `strongPage`. > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:186 > + auto* strongPage = m_page.get(); (Ditto) > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:212 > + auto* strongPage = m_page.get(); (Ditto) Committed r286065 (244452@main): <https://commits.webkit.org/244452@main> (In reply to Wenson Hsieh from comment #3) > Comment on attachment 444817 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444817&action=review > > > Source/WebKit/WebProcess/Model/ARKitInlinePreviewModelPlayer.mm:160 > > + auto* strongPage = m_page.get(); > > This should either be `RefPtr strongPage = m_page.get();`, or we shouldn't > call it `strongPage`. I adopted `RefPtr` in the commit in all places. Comment on attachment 444817 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444817&action=review > Source/WTF/ChangeLog:9 > + Add a new compile-time flag for the new autio-related ARQL SPIs we are using. "autio" |