Bug 233341

Summary: SubSpace constructors should take a const HeapCellType& instead of a HeapCellType*.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, jsbell, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233335
Attachments:
Description Flags
[fast-cq] proposed patch. none

Description Mark Lam 2021-11-18 16:22:22 PST 
This helps document that the HeapCellTypes are immutable once they are instantiated, and that SubSpaces won't be modifying them.

Also remove the const on CellAttributes return values since it is not needed nor meaningful.
Comment 1 Radar WebKit Bug Importer 2021-11-18 16:22:56 PST 
<rdar://problem/85573277>
Comment 2 Mark Lam 2021-11-18 16:30:33 PST 
Created attachment 444756 [details]
[fast-cq] proposed patch.
Comment 3 Yusuke Suzuki 2021-11-18 17:45:49 PST 
Comment on attachment 444756 [details]
[fast-cq] proposed patch.

r=me
Comment 4 Mark Lam 2021-11-18 19:01:36 PST 
Comment on attachment 444756 [details]
[fast-cq] proposed patch.

Thanks for the review.
Comment 5 EWS 2021-11-18 19:03:56 PST 
Committed r286042 (244430@main): <https://commits.webkit.org/244430@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444756 [details].