Bug 233291

Summary:

[css-values-4] Dynamic `dv*` viewport units should not respect the page scale

Product:

WebKit

Reporter:

Devin Rousso <hi>

Component:

CSS

Assignee:

Devin Rousso <hi>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

hi, simon.fraser, thorton, webkit-bug-importer, wenson_hsieh

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Bug Depends on:

219287

Bug Blocks:

238673

Attachments:

Description	Flags
Patch	none
Patch	none
Patch	none
Patch	none
Patch	none

Devin Rousso

Reported 2021-11-17 16:21:51 PST

Attachments
Patch (22.59 KB, patch) 2021-11-17 16:27 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (28.18 KB, patch) 2021-11-18 00:26 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (25.91 KB, patch) 2021-11-18 14:19 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (23.01 KB, patch) 2021-11-18 14:28 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Patch (24.68 KB, patch) 2021-11-30 12:53 PST, Devin Rousso	no flags	Details Formatted Diff Diff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.

Devin Rousso

Comment 1 2021-11-17 16:27:54 PST

Created attachment 444599 [details] Patch

Simon Fraser (smfr)

Comment 2 2021-11-17 16:35:14 PST

Comment on attachment 444599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444599&action=review > Source/WebCore/page/FrameView.cpp:5680 > + return layoutViewportRect().size(); Have you tested the behavior in MobileSafari/SFSafariViewController/Web.app?

Devin Rousso

Comment 3 2021-11-17 16:43:49 PST

Comment on attachment 444599 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444599&action=review >> Source/WebCore/page/FrameView.cpp:5680 >> + return layoutViewportRect().size(); > > Have you tested the behavior in MobileSafari/SFSafariViewController/Web.app? I tested MobileSafari and `SFSafariViewController`. I forgot about Web.app, but I just tested it there as well. All misbehave before this patch (`dv*` changes with scale) and correctly work (`dv*` is constant through scaling) after this patch :)

Devin Rousso

Comment 4 2021-11-18 00:26:08 PST

Created attachment 444644 [details] Patch

Devin Rousso

Comment 5 2021-11-18 14:19:31 PST

Created attachment 444736 [details] Patch

Devin Rousso

Comment 6 2021-11-18 14:28:28 PST

Created attachment 444738 [details] Patch

Radar WebKit Bug Importer

Comment 7 2021-11-24 16:22:21 PST

<rdar://problem/85735818>