Bug 233268

Summary: Implement most of redirect and modify-headers action types
Product: WebKit Reporter: Alex Christensen <achristensen>
Component: New BugsAssignee: Alex Christensen <achristensen>
Status: RESOLVED FIXED    
Severity: Normal CC: berto, cdumez, cgarcia, esprehn+autocc, ews-watchlist, glenn, gustavo, gyuyoung.kim, japhet, macpherson, menard, timothy, toyoshim, webkit-bug-importer, yutak
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch
none
Patch
ews-feeder: commit-queue-
Patch none

Description Alex Christensen 2021-11-17 11:51:50 PST 
Implement most of redirect and modify-headers action types
Comment 1 Alex Christensen 2021-11-17 13:20:56 PST 
Created attachment 444559 [details]
Patch
Comment 2 Alex Christensen 2021-11-17 13:51:52 PST 
Created attachment 444567 [details]
Patch
Comment 3 Alex Christensen 2021-11-17 14:30:36 PST 
Created attachment 444578 [details]
Patch
Comment 4 Alex Christensen 2021-11-17 15:39:02 PST 
Created attachment 444591 [details]
Patch
Comment 5 Timothy Hatcher 2021-11-17 15:49:54 PST 
Comment on attachment 444591 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444591&action=review

> Source/WebCore/contentextensions/ContentExtensionError.cpp:107
> +                return "A redirect ur lscheme must be a valid scheme";

"ur lscheme" => "url scheme"

> Source/WebKit/UIProcess/API/APIWebsitePolicies.cpp:106
> +        activeContentRuleListActionsPatterns(),

Should this (and in other places) be "activeContentRuleListActionPatterns" (to avoid the double plural)?
Comment 6 Alex Christensen 2021-11-17 16:32:38 PST 
Created attachment 444600 [details]
Patch
Comment 7 Alex Christensen 2021-11-17 17:06:35 PST 
Created attachment 444612 [details]
Patch
Comment 8 Alex Christensen 2021-11-17 20:18:36 PST 
Created attachment 444633 [details]
Patch
Comment 9 EWS Watchlist 2021-11-17 20:19:53 PST 
Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See https://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API
Comment 10 Alex Christensen 2021-11-17 21:38:53 PST 
r285980
Comment 11 Radar WebKit Bug Importer 2021-11-17 21:39:21 PST 
<rdar://problem/85534516>