Bug 233245

Summary: Momentum animator sometimes starts the animation at a very high velocity
Product: WebKit Reporter: Tim Horton <thorton>
Component: New BugsAssignee: Tim Horton <thorton>
Status: RESOLVED FIXED    
Severity: Normal CC: simon.fraser, webkit-bug-importer, wenson_hsieh
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch
none
Patch
none
Patch none

Tim Horton
Reported 2021-11-17 00:09:22 PST
Momentum animator sometimes starts the animation at a very high velocity
Attachments
Patch (13.29 KB, patch)
2021-11-17 00:13 PST, Tim Horton 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Patch (13.28 KB, patch)
2021-11-17 00:24 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (14.03 KB, patch)
2021-11-17 11:35 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (14.07 KB, patch)
2021-11-17 13:35 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Patch (14.07 KB, patch)
2021-11-17 13:42 PST, Tim Horton 		no flags
DetailsFormatted DiffDiff
Show Obsolete (4) View All Add attachment proposed patch, testcase, etc.
Tim Horton
Comment 1 2021-11-17 00:13:49 PST
Created attachment 444490 [details] Patch
Tim Horton
Comment 2 2021-11-17 00:14:43 PST
<rdar://problem/85307115>
Tim Horton
Comment 3 2021-11-17 00:24:56 PST
Created attachment 444491 [details] Patch
Simon Fraser (smfr)
Comment 4 2021-11-17 10:55:28 PST
Comment on attachment 444491 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444491&action=review > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:110 > + platformWheelEvent = m_recentWheelEventDeltaFilter->eventCopyWithVelocity(platformWheelEvent); Is this going to put non-zero velocity on Ended events?
Tim Horton
Comment 5 2021-11-17 11:21:31 PST
(In reply to Simon Fraser (smfr) from comment #4) > Comment on attachment 444491 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444491&action=review > > > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:110 > > + platformWheelEvent = m_recentWheelEventDeltaFilter->eventCopyWithVelocity(platformWheelEvent); > > Is this going to put non-zero velocity on Ended events? Good point, maybe we should be more restrictive (it's a little funny because you'd think velocity would be non-zero for the `end` before a `momentum start` but I know that's historically not true).
Tim Horton
Comment 6 2021-11-17 11:35:29 PST
Created attachment 444543 [details] Patch
Tim Horton
Comment 7 2021-11-17 13:35:58 PST
Created attachment 444564 [details] Patch
Tim Horton
Comment 8 2021-11-17 13:42:24 PST
Created attachment 444565 [details] Patch
EWS
Comment 9 2021-11-17 14:22:06 PST
Committed r285953 (244354@main): <https://commits.webkit.org/244354@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444565 [details].
Radar WebKit Bug Importer
Comment 10 2021-11-17 14:23:40 PST
<rdar://problem/85520965>
Note You need to log in before you can comment on or make changes to this bug.