Bug 233245 - Momentum animator sometimes starts the animation at a very high velocity
Summary: Momentum animator sometimes starts the animation at a very high velocity
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Tim Horton
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-17 00:09 PST by Tim Horton
Modified: 2021-11-17 14:23 PST (History)
3 users (show)

See Also:

Attachments
Patch (13.29 KB, patch)
2021-11-17 00:13 PST, Tim Horton 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch (13.28 KB, patch)
2021-11-17 00:24 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (14.03 KB, patch)
2021-11-17 11:35 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2021-11-17 13:35 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Patch (14.07 KB, patch)
2021-11-17 13:42 PST, Tim Horton 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tim Horton 2021-11-17 00:09:22 PST 
Momentum animator sometimes starts the animation at a very high velocity
Comment 1 Tim Horton 2021-11-17 00:13:49 PST 
Created attachment 444490 [details]
Patch
Comment 2 Tim Horton 2021-11-17 00:14:43 PST 
<rdar://problem/85307115>
Comment 3 Tim Horton 2021-11-17 00:24:56 PST 
Created attachment 444491 [details]
Patch
Comment 4 Simon Fraser (smfr) 2021-11-17 10:55:28 PST 
Comment on attachment 444491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444491&action=review

> Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:110
> +            platformWheelEvent = m_recentWheelEventDeltaFilter->eventCopyWithVelocity(platformWheelEvent);

Is this going to put non-zero velocity on Ended events?
Comment 5 Tim Horton 2021-11-17 11:21:31 PST 
(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 444491 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444491&action=review
> 
> > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:110
> > +            platformWheelEvent = m_recentWheelEventDeltaFilter->eventCopyWithVelocity(platformWheelEvent);
> 
> Is this going to put non-zero velocity on Ended events?

Good point, maybe we should be more restrictive (it's a little funny because you'd think velocity would be non-zero for the `end` before a `momentum start` but I know that's historically not true).
Comment 6 Tim Horton 2021-11-17 11:35:29 PST 
Created attachment 444543 [details]
Patch
Comment 7 Tim Horton 2021-11-17 13:35:58 PST 
Created attachment 444564 [details]
Patch
Comment 8 Tim Horton 2021-11-17 13:42:24 PST 
Created attachment 444565 [details]
Patch
Comment 9 EWS 2021-11-17 14:22:06 PST 
Committed r285953 (244354@main): <https://commits.webkit.org/244354@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444565 [details].
Comment 10 Radar WebKit Bug Importer 2021-11-17 14:23:40 PST 
<rdar://problem/85520965>