Bug 233245 – Momentum animator sometimes starts the animation at a very high velocity

• Status: RESOLVED
• Resolution: FIXED
• Component: New Bugs

[Tim Horton]

Momentum animator sometimes starts the animation at a very high velocity

[Tim Horton]

Created attachment 444490 [details]
Patch

[Tim Horton]

<rdar://problem/85307115>

[Tim Horton]

Created attachment 444491 [details]
Patch

[Simon Fraser (smfr)]

Comment on attachment 444491 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444491&action=review

> Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:110
> +            platformWheelEvent = m_recentWheelEventDeltaFilter->eventCopyWithVelocity(platformWheelEvent);

Is this going to put non-zero velocity on Ended events?

[Tim Horton]

(In reply to Simon Fraser (smfr) from comment #4)
> Comment on attachment 444491 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444491&action=review
> 
> > Source/WebKit/WebProcess/WebPage/EventDispatcher.cpp:110
> > +            platformWheelEvent = m_recentWheelEventDeltaFilter->eventCopyWithVelocity(platformWheelEvent);
> 
> Is this going to put non-zero velocity on Ended events?

Good point, maybe we should be more restrictive (it's a little funny because you'd think velocity would be non-zero for the `end` before a `momentum start` but I know that's historically not true).

[Tim Horton]

Created attachment 444543 [details]
Patch

[Tim Horton]

Created attachment 444564 [details]
Patch

[Tim Horton]

Created attachment 444565 [details]
Patch

[EWS]

Committed r285953 (244354@main): <https://commits.webkit.org/244354@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444565 [details].

[Radar WebKit Bug Importer]

<rdar://problem/85520965>