Summary: | [TextureMapper][GraphicsLayerTextureMapper][GraphicsLayerWC] setBackgroundColor support | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Fujii Hironori <Hironori.Fujii> | ||||||
Component: | Compositing | Assignee: | Fujii Hironori <Hironori.Fujii> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | annulen, clopez, cmarcelo, don.olmstead, ews-watchlist, gyuyoung.kim, kondapallykalyan, luiz, ryuan.choi, sergio, simon.fraser, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | Unspecified | ||||||||
OS: | Unspecified | ||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=235152 | ||||||||
Attachments: |
|
Description
Fujii Hironori
2021-11-16 23:57:47 PST
Created attachment 444488 [details]
Patch
Comment on attachment 444488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444488&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperSolidColorLayer.h:36 > + static Color blendWithOpacity(const Color& color, float opacity) This seems more like a utility method for Color. Anything like this already exist? Comment on attachment 444488 [details] Patch This patch causes 161 unexpected failures on GTK. This was reported by the GTK EWS Layout Test bot (still not public, is in testing phase) I tested it locally and I confirm the failures are new. Results here: https://people.igalia.com/clopez/wkbug/233244/layout-test-results/results.html (In reply to Carlos Alberto Lopez Perez from comment #3) Thank you very much! I will test it and fix. Comment on attachment 444488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444488&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperSolidColorLayer.h:36 >> + static Color blendWithOpacity(const Color& color, float opacity) > > This seems more like a utility method for Color. Anything like this already exist? Color::colorWithAlphaMultipliedBy is the one. By grepping WebKit source with colorWithAlphaMultipliedBy, some code use colorWithAlphaMultipliedBy directly. I think this color calculation for solid color layers isn't performance critical. I think we can simply use Color::colorWithAlphaMultipliedBy here. Will fix. Created attachment 444643 [details]
Patch
(In reply to Fujii Hironori from comment #6) > Created attachment 444643 [details] > Patch This last version of the patch passed just fine on the beta GTK EWS. Thanks! Comment on attachment 444643 [details] Patch Clearing flags on attachment: 444643 Committed r286046 (244433@main): <https://commits.webkit.org/244433@main> All reviewed patches have been landed. Closing bug. It introduced a bug. Filed: Bug 235152 – [WinCairo] REGRESSION(r286046): WebInspector doesn't render element highlight |