Bug 233244

Summary: [TextureMapper][GraphicsLayerTextureMapper][GraphicsLayerWC] setBackgroundColor support
Product: WebKit Reporter: Fujii Hironori <fujii.hironori>
Component: CompositingAssignee: Fujii Hironori <fujii.hironori>
Status: RESOLVED FIXED    
Severity: Normal CC: annulen, clopez, cmarcelo, don.olmstead, ews-watchlist, gyuyoung.kim, kondapallykalyan, luiz, ryuan.choi, sergio, simon.fraser, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=235152
Attachments:
Description Flags
Patch
none
Patch none

Fujii Hironori
Reported 2021-11-16 23:57:47 PST
[TextureMapper][GraphicsLayerTextureMapper][GraphicsLayerWC] setBackgroundColor support TextureMapper, GraphicsLayerTextureMapper and GraphicsLayerWC don't support setBackgroundColor now. setBackgroundColor is used for "painting flush" of Web Inspector Elements tab. 1. Start WinCairo MiniBrowser 2. Open Web Inspector 3. Push "Enable painting flush" brush icon button 4. Browsing some web sites No repaint rect is painted with semi-transparent red.
Attachments
Patch (19.06 KB, patch)
2021-11-17 00:03 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Patch (19.55 KB, patch)
2021-11-17 23:41 PST, Fujii Hironori 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Fujii Hironori
Comment 1 2021-11-17 00:03:39 PST
Created attachment 444488 [details] Patch
Don Olmstead
Comment 2 2021-11-17 14:30:01 PST
Comment on attachment 444488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444488&action=review > Source/WebCore/platform/graphics/texmap/TextureMapperSolidColorLayer.h:36 > + static Color blendWithOpacity(const Color& color, float opacity) This seems more like a utility method for Color. Anything like this already exist?
Carlos Alberto Lopez Perez
Comment 3 2021-11-17 16:25:39 PST
Comment on attachment 444488 [details] Patch This patch causes 161 unexpected failures on GTK. This was reported by the GTK EWS Layout Test bot (still not public, is in testing phase) I tested it locally and I confirm the failures are new. Results here: https://people.igalia.com/clopez/wkbug/233244/layout-test-results/results.html
Fujii Hironori
Comment 4 2021-11-17 16:39:16 PST
(In reply to Carlos Alberto Lopez Perez from comment #3) Thank you very much! I will test it and fix.
Fujii Hironori
Comment 5 2021-11-17 16:49:06 PST
Comment on attachment 444488 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444488&action=review >> Source/WebCore/platform/graphics/texmap/TextureMapperSolidColorLayer.h:36 >> + static Color blendWithOpacity(const Color& color, float opacity) > > This seems more like a utility method for Color. Anything like this already exist? Color::colorWithAlphaMultipliedBy is the one. By grepping WebKit source with colorWithAlphaMultipliedBy, some code use colorWithAlphaMultipliedBy directly. I think this color calculation for solid color layers isn't performance critical. I think we can simply use Color::colorWithAlphaMultipliedBy here. Will fix.
Fujii Hironori
Comment 6 2021-11-17 23:41:27 PST
Created attachment 444643 [details] Patch
Carlos Alberto Lopez Perez
Comment 7 2021-11-18 08:20:28 PST
(In reply to Fujii Hironori from comment #6) > Created attachment 444643 [details] > Patch This last version of the patch passed just fine on the beta GTK EWS. Thanks!
Fujii Hironori
Comment 8 2021-11-18 22:26:59 PST
Comment on attachment 444643 [details] Patch Clearing flags on attachment: 444643 Committed r286046 (244433@main): <https://commits.webkit.org/244433@main>
Fujii Hironori
Comment 9 2021-11-18 22:27:04 PST
All reviewed patches have been landed. Closing bug.
Radar WebKit Bug Importer
Comment 10 2021-11-18 22:28:22 PST
<rdar://problem/85587165>
Fujii Hironori
Comment 11 2022-01-12 13:51:23 PST
It introduced a bug. Filed: Bug 235152 – [WinCairo] REGRESSION(r286046): WebInspector doesn't render element highlight
Note You need to log in before you can comment on or make changes to this bug.