Bug 233228

Summary:

Fix for accessibility/notification-listeners.html in isolated tree mode.

Product:

WebKit

Reporter:

Andres Gonzalez <andresg_22>

Component:

Accessibility

Assignee:

Andres Gonzalez <andresg_22>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description Andres Gonzalez 2021-11-16 18:02:37 PST

Fix for accessibility/notification-listeners.html in isolated tree mode.

Comment 1 Radar WebKit Bug Importer 2021-11-16 18:02:55 PST

<rdar://problem/85484341>

Comment 2 Andres Gonzalez 2021-11-16 18:07:38 PST

Created attachment 444462 [details]
Patch

Comment 3 Tyler Wilcock 2021-11-16 18:23:27 PST

Comment on attachment 444462 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444462&action=review

> LayoutTests/accessibility/notification-listeners.html:23
> +            let select = await waitForElementById("select");

Does this need to await waitForElementById instead of accessibilityController.accessibleElementById? The selected item appears to be a static part of the document, so seems like it should be accessible by the latter.

Comment 4 Tyler Wilcock 2021-11-16 18:26:17 PST

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 444462 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444462&action=review
> 
> > LayoutTests/accessibility/notification-listeners.html:23
> > +            let select = await waitForElementById("select");
> 
> Does this need to await waitForElementById instead of
> accessibilityController.accessibleElementById? The selected item appears to
> be a static part of the document, so seems like it should be accessible by
> the latter.
Nevermind, Andres responded elsewhere that using accessibilityController.accessibleElementById in this case results in flakiness (~10 runs of 1000). It's fine to leave as-is.

Comment 5 Andres Gonzalez 2021-11-16 18:38:58 PST

Created attachment 444465 [details]
Patch

Comment 6 Andres Gonzalez 2021-11-16 18:42:32 PST

(In reply to Tyler Wilcock from comment #3)
> Comment on attachment 444462 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444462&action=review
> 
> > LayoutTests/accessibility/notification-listeners.html:23
> > +            let select = await waitForElementById("select");
> 
> Does this need to await waitForElementById instead of
> accessibilityController.accessibleElementById? The selected item appears to
> be a static part of the document, so seems like it should be accessible by
> the latter.

Thanks for pointing this out. That was my original take as well, but it turns out that if we use accessibleElementByID, the test is flaky. Added details to the ChangeLog.

Comment 7 EWS 2021-11-17 04:50:45 PST

Committed r285924 (244333@main): <https://commits.webkit.org/244333@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444465 [details].