Bug 233228

Summary: Fix for accessibility/notification-listeners.html in isolated tree mode.
Product: WebKit Reporter: Andres Gonzalez <andresg_22>
Component: AccessibilityAssignee: Andres Gonzalez <andresg_22>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, tyler_w, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Andres Gonzalez
Reported 2021-11-16 18:02:37 PST
Fix for accessibility/notification-listeners.html in isolated tree mode.
Attachments
Patch (6.79 KB, patch)
2021-11-16 18:07 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Patch (7.17 KB, patch)
2021-11-16 18:38 PST, Andres Gonzalez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-16 18:02:55 PST
<rdar://problem/85484341>
Andres Gonzalez
Comment 2 2021-11-16 18:07:38 PST
Created attachment 444462 [details] Patch
Tyler Wilcock
Comment 3 2021-11-16 18:23:27 PST
Comment on attachment 444462 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444462&action=review > LayoutTests/accessibility/notification-listeners.html:23 > + let select = await waitForElementById("select"); Does this need to await waitForElementById instead of accessibilityController.accessibleElementById? The selected item appears to be a static part of the document, so seems like it should be accessible by the latter.
Tyler Wilcock
Comment 4 2021-11-16 18:26:17 PST
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 444462 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444462&action=review > > > LayoutTests/accessibility/notification-listeners.html:23 > > + let select = await waitForElementById("select"); > > Does this need to await waitForElementById instead of > accessibilityController.accessibleElementById? The selected item appears to > be a static part of the document, so seems like it should be accessible by > the latter. Nevermind, Andres responded elsewhere that using accessibilityController.accessibleElementById in this case results in flakiness (~10 runs of 1000). It's fine to leave as-is.
Andres Gonzalez
Comment 5 2021-11-16 18:38:58 PST
Created attachment 444465 [details] Patch
Andres Gonzalez
Comment 6 2021-11-16 18:42:32 PST
(In reply to Tyler Wilcock from comment #3) > Comment on attachment 444462 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444462&action=review > > > LayoutTests/accessibility/notification-listeners.html:23 > > + let select = await waitForElementById("select"); > > Does this need to await waitForElementById instead of > accessibilityController.accessibleElementById? The selected item appears to > be a static part of the document, so seems like it should be accessible by > the latter. Thanks for pointing this out. That was my original take as well, but it turns out that if we use accessibleElementByID, the test is flaky. Added details to the ChangeLog.
EWS
Comment 7 2021-11-17 04:50:45 PST
Committed r285924 (244333@main): <https://commits.webkit.org/244333@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444465 [details].
Note You need to log in before you can comment on or make changes to this bug.