Bug 233222

Summary:

[LFC][IFC] break-word is not considered when calculating min-content intrinsic sizes.

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, koivisto, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Patch	none

Description zalan 2021-11-16 16:48:51 PST

https://drafts.csswg.org/css-text/#overflow-wrap-property

Comment 1 zalan 2021-11-16 16:50:32 PST

Created attachment 444454 [details]
Patch

Comment 2 Antti Koivisto 2021-11-16 21:28:43 PST

Comment on attachment 444454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444454&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:155
> +    bool m_isIntrinsicWidthMode { false };

m_isInIntrinsicWidthMode would read better. 

Or

enum class WidthMode : bool { Layout, Intrinsic };
WidthMode m_widthMode;

Comment 3 zalan 2021-11-17 06:36:37 PST

Created attachment 444513 [details]
Patch

Comment 4 EWS 2021-11-17 07:10:59 PST

Committed r285930 (244339@main): <https://commits.webkit.org/244339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444513 [details].

Comment 5 Radar WebKit Bug Importer 2021-11-17 07:11:22 PST

<rdar://problem/85503079>