Bug 233222 - [LFC][IFC] break-word is not considered when calculating min-content intrinsic sizes.
Summary: [LFC][IFC] break-word is not considered when calculating min-content intrinsi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: zalan
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-16 16:48 PST by zalan
Modified: 2021-11-17 07:11 PST (History)
5 users (show)

See Also:

Attachments
Patch (7.49 KB, patch)
2021-11-16 16:50 PST, zalan 		no flags Details | Formatted Diff | Diff
Patch (10.34 KB, patch)
2021-11-17 06:36 PST, zalan 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Comment 1 zalan 2021-11-16 16:50:32 PST 
Created attachment 444454 [details]
Patch
Comment 2 Antti Koivisto 2021-11-16 21:28:43 PST 
Comment on attachment 444454 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444454&action=review

> Source/WebCore/layout/formattingContexts/inline/InlineContentBreaker.h:155
> +    bool m_isIntrinsicWidthMode { false };

m_isInIntrinsicWidthMode would read better. 

Or

enum class WidthMode : bool { Layout, Intrinsic };
WidthMode m_widthMode;
Comment 3 zalan 2021-11-17 06:36:37 PST 
Created attachment 444513 [details]
Patch
Comment 4 EWS 2021-11-17 07:10:59 PST 
Committed r285930 (244339@main): <https://commits.webkit.org/244339@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444513 [details].
Comment 5 Radar WebKit Bug Importer 2021-11-17 07:11:22 PST 
<rdar://problem/85503079>