Bug 23322

Summary: gtk2drawing.c: fix compile warnings
Product: WebKit Reporter: Adam Langley <agl>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
zimmermann: review-
proposed patch v2
none
proposed patch zimmermann: review+

Adam Langley
Reported 2009-01-14 10:32:20 PST
gtk2drawing: fix compiler warnings * g_object_set_data expects a gpointer as the last argument. Cast the TRUE/FALSE values to avoid a warning. * gtk_tree_view_column_new doesn't return a GtkWidget.
Attachments
proposed patch (8.72 KB, patch)
2009-01-14 10:36 PST, Adam Langley 		zimmermann: review-
DetailsFormatted DiffDiff
proposed patch v2 (7.11 KB, patch)
2009-01-26 10:50 PST, Adam Langley 		no flags
DetailsFormatted DiffDiff
proposed patch (8.83 KB, patch)
2009-01-26 11:31 PST, Adam Langley 		zimmermann: review+
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Adam Langley
Comment 1 2009-01-14 10:36:06 PST
Created attachment 26715 [details] proposed patch
Nikolas Zimmermann
Comment 2 2009-01-22 21:00:29 PST
Comment on attachment 26715 [details] proposed patch The patch looks fine, though I think using GINT_TO_POINTER(TRUE/FALSE) sounds more approriate, then just casting to (gpointer)? I'm not a Gtk expert, but I've seen the style I suggested before.
Adam Langley
Comment 3 2009-01-26 10:50:07 PST
Created attachment 27038 [details] proposed patch v2
Adam Langley
Comment 4 2009-01-26 10:50:26 PST
Have updated patch with requested changes.
Nikolas Zimmermann
Comment 5 2009-01-26 11:20:48 PST
Hi Adam, I'm sure you've uploaded the wrong patch :-) Regards, Niko
Adam Langley
Comment 6 2009-01-26 11:31:22 PST
Created attachment 27041 [details] proposed patch
Adam Langley
Comment 7 2009-01-26 11:32:27 PST
Opps, I did upload the wrong patch! Sorry about that.
Nikolas Zimmermann
Comment 8 2009-01-26 12:16:37 PST
Comment on attachment 27041 [details] proposed patch Patch looks great, r=me. > + WARNING: NO TEST CASES ADDED OR CHANGED You can leave out the line before landing.
Darin Fisher (:fishd, Google)
Comment 9 2009-01-26 12:56:24 PST
http://trac.webkit.org/changeset/40255
Note You need to log in before you can comment on or make changes to this bug.