Bug 23322

Summary: gtk2drawing.c: fix compile warnings
Product: WebKit Reporter: Adam Langley <agl>
Component: WebKitGTKAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal    
Priority: P2    
Version: 528+ (Nightly build)   
Hardware: All   
OS: Linux   
Attachments:
Description Flags
proposed patch
zimmermann: review-
proposed patch v2
none
proposed patch zimmermann: review+

Description Adam Langley 2009-01-14 10:32:20 PST 
gtk2drawing: fix compiler warnings

* g_object_set_data expects a gpointer as the last argument. Cast the
  TRUE/FALSE values to avoid a warning.
* gtk_tree_view_column_new doesn't return a GtkWidget.
Comment 1 Adam Langley 2009-01-14 10:36:06 PST 
Created attachment 26715 [details]
proposed patch
Comment 2 Nikolas Zimmermann 2009-01-22 21:00:29 PST 
Comment on attachment 26715 [details]
proposed patch

The patch looks fine, though I think using GINT_TO_POINTER(TRUE/FALSE) sounds more approriate, then just casting to (gpointer)? I'm not a Gtk expert, but I've seen the style I suggested before.
Comment 3 Adam Langley 2009-01-26 10:50:07 PST 
Created attachment 27038 [details]
proposed patch v2
Comment 4 Adam Langley 2009-01-26 10:50:26 PST 
Have updated patch with requested changes.
Comment 5 Nikolas Zimmermann 2009-01-26 11:20:48 PST 
Hi Adam,
I'm sure you've uploaded the wrong patch :-)

Regards,
Niko
Comment 6 Adam Langley 2009-01-26 11:31:22 PST 
Created attachment 27041 [details]
proposed patch
Comment 7 Adam Langley 2009-01-26 11:32:27 PST 
Opps, I did upload the wrong patch! Sorry about that.
Comment 8 Nikolas Zimmermann 2009-01-26 12:16:37 PST 
Comment on attachment 27041 [details]
proposed patch

Patch looks great, r=me.

> +        WARNING: NO TEST CASES ADDED OR CHANGED
You can leave out the line before landing.
Comment 9 Darin Fisher (:fishd, Google) 2009-01-26 12:56:24 PST 
http://trac.webkit.org/changeset/40255