Bug 233203

Summary: Add syscall telemetry in the Networking process
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
bfulgham: review+
Patch none

Description Per Arne Vollan 2021-11-16 10:50:00 PST
Add syscall telemetry in the Networking process on macOS and iOS.
Comment 1 Per Arne Vollan 2021-11-16 10:51:46 PST
Created attachment 444409 [details]
Patch
Comment 2 Radar WebKit Bug Importer 2021-11-17 07:58:26 PST
<rdar://problem/85504351>
Comment 3 Per Arne Vollan 2021-11-17 08:02:07 PST
Created attachment 444522 [details]
Patch
Comment 4 Brent Fulgham 2021-11-17 13:48:21 PST
Comment on attachment 444522 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444522&action=review

> Source/WebKit/Scripts/process-entitlements.sh:329
> +    plistbuddy Add :com.apple.private.security.message-filter bool YES

Did you intend to add this entitlement to the GPU Process in this patch?
Comment 5 Per Arne Vollan 2021-11-17 18:26:13 PST
(In reply to Brent Fulgham from comment #4)
> Comment on attachment 444522 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444522&action=review
> 
> > Source/WebKit/Scripts/process-entitlements.sh:329
> > +    plistbuddy Add :com.apple.private.security.message-filter bool YES
> 
> Did you intend to add this entitlement to the GPU Process in this patch?

Yes, the GPU process' sandbox already has the filter, but is missing the entitlement.

Thanks for reviewing!
Comment 6 Per Arne Vollan 2021-11-18 14:19:01 PST
Created attachment 444735 [details]
Patch
Comment 7 EWS 2021-11-18 15:02:06 PST
Committed r286032 (244420@main): <https://commits.webkit.org/244420@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444735 [details].