Bug 233201

Summary:

[IFC][Integration] Clear the preferredLogicalWidths dirty bits after calling LineLayout::computeIntrinsicWidthConstraints

Product:

WebKit

Reporter:

zalan <zalan>

Component:

Layout and Rendering

Assignee:

zalan <zalan>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

bfulgham, changseok, darin, esprehn+autocc, ews-watchlist, glenn, koivisto, kondapallykalyan, pdr, simon.fraser, webkit-bug-importer, zalan

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none
Post review patch	none

Description zalan 2021-11-16 10:34:35 PST

ssia

Comment 1 zalan 2021-11-16 10:36:21 PST

Created attachment 444408 [details]
Patch

Comment 2 EWS 2021-11-17 06:20:01 PST

Committed r285925 (244334@main): <https://commits.webkit.org/244334@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444408 [details].

Comment 3 Radar WebKit Bug Importer 2021-11-17 06:21:23 PST

<rdar://problem/85501834>

Comment 4 Darin Adler 2021-11-17 09:26:21 PST

Comment on attachment 444408 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444408&action=review

> Source/WebCore/rendering/RenderBlockFlow.cpp:4583
> +    return true;
>      return true;

I think we can just keep one of these

Comment 5 zalan 2021-11-17 09:47:54 PST

(In reply to Darin Adler from comment #4)
> Comment on attachment 444408 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444408&action=review
> 
> > Source/WebCore/rendering/RenderBlockFlow.cpp:4583
> > +    return true;
> >      return true;
> 
> I think we can just keep one of these
oops!

Comment 6 zalan 2021-11-17 09:49:17 PST

(In reply to zalan from comment #5)
> (In reply to Darin Adler from comment #4)
> > Comment on attachment 444408 [details]
> > Patch
> > 
> > View in context:
> > https://bugs.webkit.org/attachment.cgi?id=444408&action=review
> > 
> > > Source/WebCore/rendering/RenderBlockFlow.cpp:4583
> > > +    return true;
> > >      return true;
> > 
> > I think we can just keep one of these
> oops!
good spotting!
thanks
thanks

Comment 7 zalan 2021-11-17 10:53:19 PST

Created attachment 444537 [details]
Post review patch

Comment 8 zalan 2021-11-17 11:03:32 PST

post review patch.

Comment 9 EWS 2021-11-17 11:48:25 PST

Committed r285946 (244349@main): <https://commits.webkit.org/244349@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444537 [details].