Bug 233198

Summary: Web Inspector: Remove unused `dontCreateIfMissing` argument from CSSStyleDeclaration.prototype.propertyForName
Product: WebKit Reporter: Nikita Vasilyev <nvasilyev>
Component: Web InspectorAssignee: Nikita Vasilyev <nvasilyev>
Status: RESOLVED FIXED    
Severity: Normal CC: ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: All   
OS: All   
Attachments:
Description Flags
Patch
none
Patch none

Nikita Vasilyev
Reported 2021-11-16 09:52:49 PST
`dontCreateIfMissing` is always true. We don't need to make it an argument.
Attachments
Patch (13.02 KB, patch)
2021-11-16 10:10 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Patch (13.99 KB, patch)
2021-11-16 13:24 PST, Nikita Vasilyev 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Nikita Vasilyev
Comment 1 2021-11-16 10:10:28 PST
Created attachment 444405 [details] Patch Never liked a negation in the argument name anyway :p
Devin Rousso
Comment 2 2021-11-16 12:29:31 PST
Comment on attachment 444405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444405&action=review > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:332 > + return bestMatchProperty; We should simplify `propertyForName` while we're at it. There's no reason to have an inline function `findMatch` that we only call once.
Nikita Vasilyev
Comment 3 2021-11-16 13:24:07 PST
Created attachment 444424 [details] Patch Done.
Devin Rousso
Comment 4 2021-11-16 13:59:07 PST
Comment on attachment 444424 [details] Patch r=me
EWS
Comment 5 2021-11-16 16:23:27 PST
Committed r285896 (244314@main): <https://commits.webkit.org/244314@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444424 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-16 16:24:22 PST
<rdar://problem/85480781>
Note You need to log in before you can comment on or make changes to this bug.