Summary: | Web Inspector: Remove unused `dontCreateIfMissing` argument from CSSStyleDeclaration.prototype.propertyForName | ||||||||
---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Nikita Vasilyev <nvasilyev> | ||||||
Component: | Web Inspector | Assignee: | Nikita Vasilyev <nvasilyev> | ||||||
Status: | RESOLVED FIXED | ||||||||
Severity: | Normal | CC: | ews-watchlist, hi, inspector-bugzilla-changes, pangle, webkit-bug-importer | ||||||
Priority: | P2 | Keywords: | InRadar | ||||||
Version: | WebKit Nightly Build | ||||||||
Hardware: | All | ||||||||
OS: | All | ||||||||
Attachments: |
|
Description
Nikita Vasilyev
2021-11-16 09:52:49 PST
Created attachment 444405 [details]
Patch
Never liked a negation in the argument name anyway :p
Comment on attachment 444405 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444405&action=review > Source/WebInspectorUI/UserInterface/Models/CSSStyleDeclaration.js:332 > + return bestMatchProperty; We should simplify `propertyForName` while we're at it. There's no reason to have an inline function `findMatch` that we only call once. Created attachment 444424 [details]
Patch
Done.
Comment on attachment 444424 [details]
Patch
r=me
Committed r285896 (244314@main): <https://commits.webkit.org/244314@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444424 [details]. |