Bug 233191

Summary: [iOS] Do not require the web browser entitlement to opt into captive portal mode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Description Chris Dumez 2021-11-16 08:02:56 PST 
Do not require the web browser entitlement to opt into captive portal mode on iOS, only require it to opt out.
Comment 1 Chris Dumez 2021-11-16 08:04:50 PST 
Created attachment 444385 [details]
Patch
Comment 2 Brent Fulgham 2021-11-16 08:08:05 PST 
Comment on attachment 444385 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444385&action=review

r=me

> Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7750
> +        [preferences _setCaptivePortalModeEnabled:NO];

Nit: Whitespace is wrong here.
Comment 3 Chris Dumez 2021-11-16 08:14:33 PST 
Created attachment 444388 [details]
Patch
Comment 4 Brent Fulgham 2021-11-16 08:21:29 PST 
Comment on attachment 444388 [details]
Patch

Thank you!
Comment 5 EWS 2021-11-16 10:28:04 PST 
Committed r285873 (244299@main): <https://commits.webkit.org/244299@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444388 [details].
Comment 6 Radar WebKit Bug Importer 2021-11-16 10:29:35 PST 
<rdar://problem/85464810>