Bug 233191

Summary: [iOS] Do not require the web browser entitlement to opt into captive portal mode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ggaren, kkinnunen, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Chris Dumez
Reported 2021-11-16 08:02:56 PST
Do not require the web browser entitlement to opt into captive portal mode on iOS, only require it to opt out.
Attachments
Patch (6.32 KB, patch)
2021-11-16 08:04 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (6.32 KB, patch)
2021-11-16 08:14 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-11-16 08:04:50 PST
Created attachment 444385 [details] Patch
Brent Fulgham
Comment 2 2021-11-16 08:08:05 PST
Comment on attachment 444385 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444385&action=review r=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7750 > + [preferences _setCaptivePortalModeEnabled:NO]; Nit: Whitespace is wrong here.
Chris Dumez
Comment 3 2021-11-16 08:14:33 PST
Created attachment 444388 [details] Patch
Brent Fulgham
Comment 4 2021-11-16 08:21:29 PST
Comment on attachment 444388 [details] Patch Thank you!
EWS
Comment 5 2021-11-16 10:28:04 PST
Committed r285873 (244299@main): <https://commits.webkit.org/244299@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444388 [details].
Radar WebKit Bug Importer
Comment 6 2021-11-16 10:29:35 PST
<rdar://problem/85464810>
Note You need to log in before you can comment on or make changes to this bug.