Summary: | Adjust graphics related message filter | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Per Arne Vollan <pvollan> | ||||||||||
Component: | WebKit Misc. | Assignee: | Per Arne Vollan <pvollan> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | bfulgham, gavin.p, mazander, webkit-bug-importer | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
Attachments: |
|
Description
Per Arne Vollan
2021-11-15 14:51:55 PST
Created attachment 444309 [details]
Patch
Created attachment 444410 [details]
Patch
Created attachment 444413 [details]
Patch
Comment on attachment 444413 [details]
Patch
r=me
Comment on attachment 444413 [details]
Patch
Thanks for reviewing!
Committed r285878 (244304@main): <https://commits.webkit.org/244304@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444413 [details]. Reopening to attach new patch. Created attachment 444426 [details]
Patch
Comment on attachment 444426 [details]
Patch
r=me
Comment on attachment 444426 [details]
Patch
Thanks for reviewing!
Committed r285889 (244311@main): <https://commits.webkit.org/244311@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444426 [details]. Comment on attachment 444426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444426&action=review > Source/WebKit/ChangeLog:9 > + Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies This patch doesn't touch the iOS profile, which is in Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in. So seems like either the comment or the patch is incorrect? I do see that there is another patch in this bug that does touch iOS; my question is about this patch that was landed too. (In reply to Alexey Proskuryakov from comment #13) > Comment on attachment 444426 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444426&action=review > > > Source/WebKit/ChangeLog:9 > > + Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies > > This patch doesn't touch the iOS profile, which is in > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb. > in. So seems like either the comment or the patch is incorrect? > > I do see that there is another patch in this bug that does touch iOS; my > question is about this patch that was landed too. Yes, you're right, the Change log comment is incorrect here, since the second patch only touches macOS. Thanks for reviewing! |