Bug 233151

Summary: Adjust graphics related message filter
Product: WebKit Reporter: Per Arne Vollan <pvollan>
Component: WebKit Misc.Assignee: Per Arne Vollan <pvollan>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, gavin.p, mazander, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Per Arne Vollan
Reported 2021-11-15 14:51:55 PST
Adjust graphics related message filter in the WebContent process on iOS.
Attachments
Patch (2.02 KB, patch)
2021-11-15 14:55 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2021-11-16 10:58 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (3.19 KB, patch)
2021-11-16 11:02 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Patch (1.66 KB, patch)
2021-11-16 14:08 PST, Per Arne Vollan 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Per Arne Vollan
Comment 1 2021-11-15 14:55:52 PST
Created attachment 444309 [details] Patch
Radar WebKit Bug Importer
Comment 2 2021-11-15 15:01:38 PST
<rdar://problem/85430575>
Per Arne Vollan
Comment 3 2021-11-16 10:58:25 PST
Created attachment 444410 [details] Patch
Per Arne Vollan
Comment 4 2021-11-16 11:02:00 PST
Created attachment 444413 [details] Patch
Brent Fulgham
Comment 5 2021-11-16 11:25:04 PST
Comment on attachment 444413 [details] Patch r=me
Per Arne Vollan
Comment 6 2021-11-16 11:29:29 PST
Comment on attachment 444413 [details] Patch Thanks for reviewing!
EWS
Comment 7 2021-11-16 12:20:53 PST
Committed r285878 (244304@main): <https://commits.webkit.org/244304@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444413 [details].
Per Arne Vollan
Comment 8 2021-11-16 14:08:49 PST
Reopening to attach new patch.
Per Arne Vollan
Comment 9 2021-11-16 14:08:50 PST
Created attachment 444426 [details] Patch
Brent Fulgham
Comment 10 2021-11-16 14:10:25 PST
Comment on attachment 444426 [details] Patch r=me
Per Arne Vollan
Comment 11 2021-11-16 14:20:13 PST
Comment on attachment 444426 [details] Patch Thanks for reviewing!
EWS
Comment 12 2021-11-16 14:54:06 PST
Committed r285889 (244311@main): <https://commits.webkit.org/244311@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444426 [details].
Alexey Proskuryakov
Comment 13 2021-11-18 11:40:21 PST
Comment on attachment 444426 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444426&action=review > Source/WebKit/ChangeLog:9 > + Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies This patch doesn't touch the iOS profile, which is in Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb.in. So seems like either the comment or the patch is incorrect? I do see that there is another patch in this bug that does touch iOS; my question is about this patch that was landed too.
Per Arne Vollan
Comment 14 2021-11-18 11:49:52 PST
(In reply to Alexey Proskuryakov from comment #13) > Comment on attachment 444426 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444426&action=review > > > Source/WebKit/ChangeLog:9 > > + Adjust graphics related message filter in the WebContent process' sandbox on iOS. This patch unifies > > This patch doesn't touch the iOS profile, which is in > Source/WebKit/Resources/SandboxProfiles/ios/com.apple.WebKit.WebContent.sb. > in. So seems like either the comment or the patch is incorrect? > > I do see that there is another patch in this bug that does touch iOS; my > question is about this patch that was landed too. Yes, you're right, the Change log comment is incorrect here, since the second patch only touches macOS. Thanks for reviewing!
Note You need to log in before you can comment on or make changes to this bug.