Bug 233149

Summary:

[fast-cq] Enable webpushd tests in the iOS simulator

Product:

WebKit

Reporter:

Brady Eidson <beidson>

Component:

WebKit Misc.

Assignee:

Brady Eidson <beidson>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

achristensen, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch v1	achristensen: review+
Patch for landing v1	ews-feeder: commit-queue-
Patch for landing v2	ews-feeder: commit-queue-
[fast-cq] PFL	none

Brady Eidson

Reported 2021-11-15 14:39:22 PST

Enable webpushd tests in the iOS simulator

Attachments
Patch v1 (3.68 KB, patch) 2021-11-15 14:41 PST, Brady Eidson	achristensen: review+	Details Formatted Diff Diff
Patch for landing v1 (4.17 KB, patch) 2021-11-15 19:09 PST, Brady Eidson	ews-feeder: commit-queue-	Details Formatted Diff Diff
Patch for landing v2 (4.17 KB, patch) 2021-11-15 20:21 PST, Brady Eidson	ews-feeder: commit-queue-	Details Formatted Diff Diff
[fast-cq] PFL (4.17 KB, patch) 2021-11-16 09:05 PST, Brady Eidson	no flags	Details Formatted Diff Diff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.

Brady Eidson

Comment 1 2021-11-15 14:41:06 PST

Created attachment 444305 [details] Patch v1

Alex Christensen

Comment 2 2021-11-15 14:45:31 PST

Comment on attachment 444305 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=444305&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:35 > +#if PLATFORM(MAC) || PLATFORM(IOS) You may consider just removing this

Brady Eidson

Comment 3 2021-11-15 14:48:22 PST

(In reply to Alex Christensen from comment #2) > Comment on attachment 444305 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444305&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:35 > > +#if PLATFORM(MAC) || PLATFORM(IOS) > > You may consider just removing this TestWebKitAPI actually builds for some other Cocoa platforms that aren't ready to try and build this one 👍

Brady Eidson

Comment 4 2021-11-15 19:09:19 PST

Created attachment 444328 [details] Patch for landing v1

Brady Eidson

Comment 5 2021-11-15 20:21:57 PST

Created attachment 444335 [details] Patch for landing v2 Now with fewer typos and more building!

EWS

Comment 6 2021-11-16 07:55:33 PST

ChangeLog entry in Tools/ChangeLog contains OOPS!.

Brady Eidson

Comment 7 2021-11-16 09:05:44 PST

Created attachment 444398 [details] [fast-cq] PFL

EWS

Comment 8 2021-11-16 09:39:16 PST

Committed r285870 (244296@main): <https://commits.webkit.org/244296@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444398 [details].

Radar WebKit Bug Importer

Comment 9 2021-11-16 09:40:23 PST

<rdar://problem/85462346>

Note You need to log in before you can comment on or make changes to this bug.