| Summary: | [fast-cq] Enable webpushd tests in the iOS simulator | ||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Brady Eidson <beidson> | ||||||||||
| Component: | WebKit Misc. | Assignee: | Brady Eidson <beidson> | ||||||||||
| Status: | RESOLVED FIXED | ||||||||||||
| Severity: | Normal | CC: | achristensen, webkit-bug-importer | ||||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||||
| Version: | WebKit Nightly Build | ||||||||||||
| Hardware: | Unspecified | ||||||||||||
| OS: | Unspecified | ||||||||||||
| Attachments: |
|
||||||||||||
|
Description
Brady Eidson
2021-11-15 14:39:22 PST
Created attachment 444305 [details]
Patch v1
Comment on attachment 444305 [details] Patch v1 View in context: https://bugs.webkit.org/attachment.cgi?id=444305&action=review > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:35 > +#if PLATFORM(MAC) || PLATFORM(IOS) You may consider just removing this (In reply to Alex Christensen from comment #2) > Comment on attachment 444305 [details] > Patch v1 > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444305&action=review > > > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:35 > > +#if PLATFORM(MAC) || PLATFORM(IOS) > > You may consider just removing this TestWebKitAPI actually builds for some other Cocoa platforms that aren't ready to try and build this one 👍 Created attachment 444328 [details]
Patch for landing v1
Created attachment 444335 [details]
Patch for landing v2
Now with fewer typos and more building!
ChangeLog entry in Tools/ChangeLog contains OOPS!. Created attachment 444398 [details]
[fast-cq] PFL
Committed r285870 (244296@main): <https://commits.webkit.org/244296@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444398 [details]. |