Bug 233149 - [fast-cq] Enable webpushd tests in the iOS simulator
Summary: [fast-cq] Enable webpushd tests in the iOS simulator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brady Eidson
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-15 14:39 PST by Brady Eidson
Modified: 2021-11-16 09:40 PST (History)
2 users (show)

See Also:


Attachments
Patch v1 (3.68 KB, patch)
2021-11-15 14:41 PST, Brady Eidson
achristensen: review+
Details | Formatted Diff | Diff
Patch for landing v1 (4.17 KB, patch)
2021-11-15 19:09 PST, Brady Eidson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Patch for landing v2 (4.17 KB, patch)
2021-11-15 20:21 PST, Brady Eidson
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
[fast-cq] PFL (4.17 KB, patch)
2021-11-16 09:05 PST, Brady Eidson
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brady Eidson 2021-11-15 14:39:22 PST
Enable webpushd tests in the iOS simulator
Comment 1 Brady Eidson 2021-11-15 14:41:06 PST
Created attachment 444305 [details]
Patch v1
Comment 2 Alex Christensen 2021-11-15 14:45:31 PST
Comment on attachment 444305 [details]
Patch v1

View in context: https://bugs.webkit.org/attachment.cgi?id=444305&action=review

> Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:35
> +#if PLATFORM(MAC) || PLATFORM(IOS)

You may consider just removing this
Comment 3 Brady Eidson 2021-11-15 14:48:22 PST
(In reply to Alex Christensen from comment #2)
> Comment on attachment 444305 [details]
> Patch v1
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444305&action=review
> 
> > Tools/TestWebKitAPI/Tests/WebKitCocoa/WebPushDaemon.mm:35
> > +#if PLATFORM(MAC) || PLATFORM(IOS)
> 
> You may consider just removing this

TestWebKitAPI actually builds for some other Cocoa platforms that aren't ready to try and build this one 👍
Comment 4 Brady Eidson 2021-11-15 19:09:19 PST
Created attachment 444328 [details]
Patch for landing v1
Comment 5 Brady Eidson 2021-11-15 20:21:57 PST
Created attachment 444335 [details]
Patch for landing v2

Now with fewer typos and more building!
Comment 6 EWS 2021-11-16 07:55:33 PST
ChangeLog entry in Tools/ChangeLog contains OOPS!.
Comment 7 Brady Eidson 2021-11-16 09:05:44 PST
Created attachment 444398 [details]
[fast-cq] PFL
Comment 8 EWS 2021-11-16 09:39:16 PST
Committed r285870 (244296@main): <https://commits.webkit.org/244296@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444398 [details].
Comment 9 Radar WebKit Bug Importer 2021-11-16 09:40:23 PST
<rdar://problem/85462346>