| Summary: | Remove some dead code from IPC::Encoder / IPC::Decoder | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||
| Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | achristensen, darin, ggaren, kkinnunen, sam, webkit-bug-importer, youennf | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
Chris Dumez
2021-11-15 09:52:39 PST
Created attachment 444268 [details]
Patch
Committed r285818 (244260@main): <https://commits.webkit.org/244260@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444268 [details]. Comment on attachment 444268 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444268&action=review > Source/WebKit/Platform/IPC/Decoder.h:63 > Decoder(const Decoder&) = delete; > Decoder(Decoder&&) = delete; > + Decoder& operator=(const Decoder&) = delete; > + Decoder& operator=(Decoder&&) = delete; I understand the elegance of explicitly deleting both the copy and move constructor and assignment operator, but keep in mind that if you delete the copy and don’t define a move you will get a compilation error just you would if it was deleted. So you don’t need to delete the move ones. > Source/WebKit/Platform/IPC/Encoder.h:52 > + Encoder(const Encoder&) = delete; > + Encoder(Encoder&&) = delete; > + Encoder& operator=(const Encoder&) = delete; > + Encoder& operator=(Encoder&&) = delete; Ditto. |