Bug 233119

Summary: Stack overflow with revert-layer
Product: WebKit Reporter: Antti Koivisto <koivisto>
Component: CSSAssignee: Antti Koivisto <koivisto>
Status: RESOLVED FIXED    
Severity: Normal CC: graouts, msaboff, ntim
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Antti Koivisto
Reported 2021-11-15 00:49:05 PST
boom
Attachments
Patch (6.93 KB, patch)
2021-11-15 01:01 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Patch (6.39 KB, patch)
2021-11-15 01:37 PST, Antti Koivisto 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Antti Koivisto
Comment 1 2021-11-15 00:51:03 PST
rdar://85342210
Antti Koivisto
Comment 2 2021-11-15 01:01:20 PST
Created attachment 444219 [details] Patch
Tim Nguyen (:ntim)
Comment 3 2021-11-15 01:35:04 PST
Comment on attachment 444219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444219&action=review > Source/WebCore/style/StyleBuilder.cpp:398 > if (!rollbackLayerPriority) > - return nullptr; > + return ensureRollbackCascadeForRevert(cascadeLevel); There should be tests for this, that revert-layer behaves like revert with no layers.
Antti Koivisto
Comment 4 2021-11-15 01:37:39 PST
Created attachment 444223 [details] Patch
Antti Koivisto
Comment 5 2021-11-15 01:38:13 PST
Comment on attachment 444219 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444219&action=review >> Source/WebCore/style/StyleBuilder.cpp:398 >> + return ensureRollbackCascadeForRevert(cascadeLevel); > > There should be tests for this, that revert-layer behaves like revert with no layers. I'll do the change separately.
EWS
Comment 6 2021-11-15 03:12:40 PST
Committed r285801 (244245@main): <https://commits.webkit.org/244245@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444223 [details].
Antti Koivisto
Comment 7 2021-11-15 03:19:59 PST
*** Bug 233068 has been marked as a duplicate of this bug. ***
Note You need to log in before you can comment on or make changes to this bug.