| Summary: | Implement UIScriptController.sendEventStream() for DumpRenderTree | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Component: | Tools / Tests | Assignee: | Simon Fraser (smfr) <simon.fraser> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | simon.fraser, webkit-bug-importer, wenson_hsieh | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Simon Fraser (smfr)
2021-11-13 13:19:25 PST
Created attachment 444147 [details]
Patch
Comment on attachment 444147 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444147&action=review r=mews > Tools/DumpRenderTree/mac/EventSendingController.mm:888 > + // Note that the delta get convered to integral values here. NSEvent has float deltas, CGEvent has integral deltas. sp. - "convered" > Tools/DumpRenderTree/mac/UIScriptControllerMac.mm:178 > +static NSString* const TopLevelEventInfoKey = @"events"; Nit - * on the wrong side for these constants. Created attachment 444150 [details]
Patch
Committed r285781 (244225@main): <https://commits.webkit.org/244225@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444150 [details]. |