Summary: | Chromium crashes with custom cursors | ||
---|---|---|---|
Product: | WebKit | Reporter: | Ananta Iyengar <ananta> |
Component: | Images | Assignee: | Nobody <webkit-unassigned> |
Status: | RESOLVED FIXED | ||
Severity: | Normal | ||
Priority: | P2 | ||
Version: | 528+ (Nightly build) | ||
Hardware: | PC | ||
OS: | Windows XP | ||
Attachments: |
Description
Ananta Iyengar
2009-01-13 16:47:57 PST
Created attachment 26699 [details]
Contains the fix for the custom cursor crash with Chromium
Comment on attachment 26699 [details]
Contains the fix for the custom cursor crash with Chromium
There are some unrelated changes in this patch. Will upload a new one shortly
Created attachment 26700 [details]
Fix for the cursor crash with Chromium
Comment on attachment 26700 [details] Fix for the cursor crash with Chromium The ChangeList wrong. You you set EMAIL_ADDRESS in your local environment so future runs of prepare-ChangeLog know what your email address is (iyengar@chromium.org). Your REAL_NAME value should also be set to something other than "iyengar" (currently it's falling back onto your username). I would revert your local ChangeLog and run prepare-ChangeLog again (once and only once). You seem to have corrected setData to 8 spaces of indent from 6 spaces on all platforms except chromium. :) Created attachment 26702 [details]
Fix for the custom cursor crash with Chromium. Updated based on code review comments by Eric
I have uploaded a new patch which addresses these comments. Please take another look. -Ananta (In reply to comment #4) > (From update of attachment 26700 [details] [review]) > The ChangeList wrong. You you set EMAIL_ADDRESS in your local environment so > future runs of prepare-ChangeLog know what your email address is > (iyengar@chromium.org). Your REAL_NAME value should also be set to something > other than "iyengar" (currently it's falling back onto your username). I would > revert your local ChangeLog and run prepare-ChangeLog again (once and only > once). > > You seem to have corrected setData to 8 spaces of indent from 6 spaces on all > platforms except chromium. :) > Comment on attachment 26702 [details]
Fix for the custom cursor crash with Chromium. Updated based on code review comments by Eric
I had added comments by mistake to the diff directly. Will upload a new patch
Created attachment 26800 [details]
Updated patch created off the changelog this time.
separate the style changes from the actual fix? Comment on attachment 26800 [details]
Updated patch created off the changelog this time.
ChangeLog needs to be fix to Ananta's full name when landing. There is also a Tab in the changelog. Otherwise this looks fine.
Comment on attachment 26800 [details]
Updated patch created off the changelog this time.
Will update a new patch based on the comments by Eric.
Created attachment 27369 [details]
Updated patch with the reviewer name fixed and tab removed.
Landed as http://trac.webkit.org/changeset/40722. Comment on attachment 27369 [details]
Updated patch with the reviewer name fixed and tab removed.
Clearing review flag to remove from queue.
|