Bug 233072

Summary: ::backdrop pseudo element should react to event listeners
Product: WebKit Reporter: Tim Nguyen (:ntim) <ntim>
Component: DOMAssignee: Tim Nguyen (:ntim) <ntim>
Status: RESOLVED FIXED    
Severity: Normal CC: changseok, esprehn+autocc, ews-watchlist, glenn, kondapallykalyan, pdr, webkit-bug-importer, zalan
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 84635    
Attachments:
Description Flags
Patch
zalan: review+, ews-feeder: commit-queue-
Patch none

Description Tim Nguyen (:ntim) 2021-11-12 14:01:16 PST
```
<dialog id=dialog onclick="alert('clicked')">hello</dialog>

<script>
dialog.showModal()
</script>
```

the onclick does not work on the ::backdrop, it does in Firefox/Chrome.
Comment 1 Radar WebKit Bug Importer 2021-11-12 15:27:22 PST
<rdar://problem/85359803>
Comment 3 Tim Nguyen (:ntim) 2022-01-10 12:53:06 PST
Created attachment 448789 [details]
Patch
Comment 4 zalan 2022-01-10 17:31:37 PST
Comment on attachment 448789 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=448789&action=review

> Source/WebCore/rendering/updating/RenderTreeUpdaterGeneratedContent.cpp:201
> -    // Update or attach to renderer parent
> +    // Update or attach to renderer
>      WeakPtr currentParent = backdropRenderer->parent();
> -    WeakPtr newParent = renderer.parent();
> +    WeakPtr newParent = renderer;

auto backdropRenderer = renderer.backdropRenderer();
   ...
    renderer.setBackdropRenderer(*backdropRenderer);

don't we always end up either with no backdropRenderer or with one with the correct parent (renderer)? I didn't look through all the cases but could you explain the re-parenting case? (if no reparenting ever happens, we could make this function a lot simpler)
Comment 5 Tim Nguyen (:ntim) 2022-01-11 06:34:44 PST
Created attachment 448843 [details]
Patch
Comment 6 EWS 2022-01-11 07:19:36 PST
Committed r287878 (245922@main): <https://commits.webkit.org/245922@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 448843 [details].