| Summary: | [JSC] update test262 | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Joseph Griego <joseph.j.griego> | ||||||
| Component: | New Bugs | Assignee: | Nobody <webkit-unassigned> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Normal | CC: | ashvayka, keith_miller, mark.lam, ross.kirsling, webkit-bug-importer, ysuzuki | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | Unspecified | ||||||||
| OS: | Unspecified | ||||||||
| Attachments: |
|
||||||||
|
Description
Joseph Griego
2021-11-12 12:11:42 PST
Created attachment 444088 [details]
Patch
Did you run it on macOS Monterey? Currently our bot is based on that machine. Hi! First time sending a patch--trying to pick up some changes for the ShadowRealm tests. ysuzuki: i don't have access to a macos machine--i figured I would wait for CI and verify the expectation file based on that? I see, apologies. It looks like the bot in question runs only after landing? I'll see what I can do to run on the right platform, or close this. (Or whatever else you advise) (In reply to Joseph Griego from comment #4) > I see, apologies. It looks like the bot in question runs only after landing? > I'll see what I can do to run on the right platform, or close this. (Or > whatever else you advise) OK, so can you monitor the bot after landing and fix the bot after failures are listed? (In reply to Yusuke Suzuki from comment #5) > (In reply to Joseph Griego from comment #4) > > I see, apologies. It looks like the bot in question runs only after landing? > > I'll see what I can do to run on the right platform, or close this. (Or > > whatever else you advise) > > OK, so can you monitor the bot after landing and fix the bot after failures > are listed? Please land it when you can monitor the bot :) Created attachment 444112 [details]
Patch
patch fixed for the right version of macos, thank you rkirsling ':) Committed r285760 (244209@main): <https://commits.webkit.org/244209@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444112 [details]. |