Bug 233058

Summary: [JSC] update test262
Product: WebKit Reporter: Joseph Griego <joseph.j.griego>
Component: New BugsAssignee: Nobody <webkit-unassigned>
Status: RESOLVED FIXED    
Severity: Normal CC: ashvayka, keith_miller, mark.lam, ross.kirsling, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch none

Joseph Griego
Reported 2021-11-12 12:11:42 PST
[JSC] update test262
Attachments
Patch (314.34 KB, patch)
2021-11-12 12:23 PST, Joseph Griego 		no flags
DetailsFormatted DiffDiff
Patch (307.73 KB, patch)
2021-11-12 14:55 PST, Joseph Griego 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Joseph Griego
Comment 1 2021-11-12 12:23:56 PST
Created attachment 444088 [details] Patch
Yusuke Suzuki
Comment 2 2021-11-12 12:24:51 PST
Did you run it on macOS Monterey? Currently our bot is based on that machine.
Joseph Griego
Comment 3 2021-11-12 12:27:23 PST
Hi! First time sending a patch--trying to pick up some changes for the ShadowRealm tests. ysuzuki: i don't have access to a macos machine--i figured I would wait for CI and verify the expectation file based on that?
Joseph Griego
Comment 4 2021-11-12 13:03:49 PST
I see, apologies. It looks like the bot in question runs only after landing? I'll see what I can do to run on the right platform, or close this. (Or whatever else you advise)
Yusuke Suzuki
Comment 5 2021-11-12 13:05:36 PST
(In reply to Joseph Griego from comment #4) > I see, apologies. It looks like the bot in question runs only after landing? > I'll see what I can do to run on the right platform, or close this. (Or > whatever else you advise) OK, so can you monitor the bot after landing and fix the bot after failures are listed?
Yusuke Suzuki
Comment 6 2021-11-12 13:05:56 PST
(In reply to Yusuke Suzuki from comment #5) > (In reply to Joseph Griego from comment #4) > > I see, apologies. It looks like the bot in question runs only after landing? > > I'll see what I can do to run on the right platform, or close this. (Or > > whatever else you advise) > > OK, so can you monitor the bot after landing and fix the bot after failures > are listed? Please land it when you can monitor the bot :)
Joseph Griego
Comment 7 2021-11-12 14:55:45 PST
Created attachment 444112 [details] Patch
Joseph Griego
Comment 8 2021-11-12 14:57:39 PST
patch fixed for the right version of macos, thank you rkirsling ':)
EWS
Comment 9 2021-11-12 16:08:12 PST
Committed r285760 (244209@main): <https://commits.webkit.org/244209@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444112 [details].
Radar WebKit Bug Importer
Comment 10 2021-11-12 16:09:23 PST
<rdar://problem/85361163>
Note You need to log in before you can comment on or make changes to this bug.