Bug 233052

Summary: REGRESSION (r285698): Build correction after refactoring id handling
Product: WebKit Reporter: Brent Fulgham <bfulgham>
Component: WebKit Misc.Assignee: Brent Fulgham <bfulgham>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, cdumez, ews-watchlist, jiewen_tan, ryanhaddad, tsavell, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch none

Brent Fulgham
Reported 2021-11-12 10:49:52 PST
In r285698 I added a new 'toNSData' inline for BufferSource, which is used in WebAuthenticatorCoordinatorProxy.mm. At the last minute, we decided to not export the function without its namespace but forgot to update WebAuthenticatorCoordinatorProxy.mm with that change. I missed this locally because I didn't do a clean build.
Attachments
Patch (4.47 KB, patch)
2021-11-12 10:54 PST, Brent Fulgham 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Brent Fulgham
Comment 1 2021-11-12 10:50:10 PST
<rdar://problem/85347865>
Brent Fulgham
Comment 2 2021-11-12 10:54:51 PST
Created attachment 444083 [details] Patch
EWS
Comment 3 2021-11-12 12:15:46 PST
Committed r285736 (244195@main): <https://commits.webkit.org/244195@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444083 [details].
Note You need to log in before you can comment on or make changes to this bug.