Bug 233052 - REGRESSION (r285698): Build correction after refactoring id handling
Summary: REGRESSION (r285698): Build correction after refactoring id handling
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Brent Fulgham
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2021-11-12 10:49 PST by Brent Fulgham
Modified: 2021-11-12 12:20 PST (History)
7 users (show)

See Also:

Attachments
Patch (4.47 KB, patch)
2021-11-12 10:54 PST, Brent Fulgham 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brent Fulgham 2021-11-12 10:49:52 PST 
In r285698 I added a new 'toNSData' inline for BufferSource, which is used in WebAuthenticatorCoordinatorProxy.mm.

At the last minute, we decided to not export the function without its namespace but forgot to update WebAuthenticatorCoordinatorProxy.mm with that change.

I missed this locally because I didn't do a clean build.
Comment 1 Brent Fulgham 2021-11-12 10:50:10 PST 
<rdar://problem/85347865>
Comment 2 Brent Fulgham 2021-11-12 10:54:51 PST 
Created attachment 444083 [details]
Patch
Comment 3 EWS 2021-11-12 12:15:46 PST 
Committed r285736 (244195@main): <https://commits.webkit.org/244195@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444083 [details].