Bug 233028

Summary: Refactor allocateCell() and tryAllocateCell() to take VM& instead of Heap&.
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: alecflett, beidson, cdumez, ews-watchlist, hi, joepeck, jsbell, keith_miller, msaboff, pangle, saam, tzagallo, webkit-bug-importer, ysuzuki
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232849    
Attachments:
Description Flags
proposed patch.
ews-feeder: commit-queue-
proposed patch.
ews-feeder: commit-queue-
proposed patch. ysuzuki: review+, ews-feeder: commit-queue-

Mark Lam
Reported 2021-11-11 21:34:14 PST
allocateCell() and tryAllocateCell() can fetch Heap& from VM& themselves. This allows us to make all the client code more terse, and also makes it easier to redirect the underlying heap to allocate from later for global GC work. Additionally, this will help make the global GC patch less of a mega patch and easier to review later.
Attachments
proposed patch. (336.66 KB, patch)
2021-11-11 21:42 PST, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (521.76 KB, patch)
2021-11-11 22:06 PST, Mark Lam 		ews-feeder: commit-queue-
DetailsFormatted DiffDiff
proposed patch. (523.99 KB, patch)
2021-11-11 22:46 PST, Mark Lam 		ysuzuki: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-11 21:34:57 PST
<rdar://problem/85329680>
Mark Lam
Comment 2 2021-11-11 21:42:32 PST
Created attachment 444042 [details] proposed patch.
Mark Lam
Comment 3 2021-11-11 22:06:00 PST
Created attachment 444045 [details] proposed patch.
Mark Lam
Comment 4 2021-11-11 22:46:06 PST
Created attachment 444049 [details] proposed patch.
Yusuke Suzuki
Comment 5 2021-11-12 01:01:16 PST
Comment on attachment 444049 [details] proposed patch. r=me
Mark Lam
Comment 6 2021-11-12 10:12:09 PST
The mac-wk1 EWS failed tests is due to a known flaky crash on that test fast/dom/Geolocation/cached-position-iframe.html. Hence, it's not related to this patch.
Mark Lam
Comment 7 2021-11-12 10:17:39 PST
Thanks for the review. Landed in r285730: <http://trac.webkit.org/r285730>.
Note You need to log in before you can comment on or make changes to this bug.