Bug 233028 - Refactor allocateCell() and tryAllocateCell() to take VM& instead of Heap&.
Summary: Refactor allocateCell() and tryAllocateCell() to take VM& instead of Heap&.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Mark Lam
URL:
Keywords: InRadar
Depends on:
Blocks: 232849
  Show dependency tree / graph
 
Reported: 2021-11-11 21:34 PST by Mark Lam
Modified: 2021-11-12 10:17 PST (History)
14 users (show)

See Also:

Attachments
proposed patch. (336.66 KB, patch)
2021-11-11 21:42 PST, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (521.76 KB, patch)
2021-11-11 22:06 PST, Mark Lam 		ews-feeder: commit-queue-
Details | Formatted Diff | Diff
proposed patch. (523.99 KB, patch)
2021-11-11 22:46 PST, Mark Lam 		ysuzuki: review+
ews-feeder: commit-queue-
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mark Lam 2021-11-11 21:34:14 PST 
allocateCell() and tryAllocateCell() can fetch Heap& from VM& themselves.  This allows us to make all the client code more terse, and also makes it easier to redirect the underlying heap to allocate from later for global GC work.  Additionally, this will help make the global GC patch less of a mega patch and easier to review later.
Comment 1 Radar WebKit Bug Importer 2021-11-11 21:34:57 PST 
<rdar://problem/85329680>
Comment 2 Mark Lam 2021-11-11 21:42:32 PST 
Created attachment 444042 [details]
proposed patch.
Comment 3 Mark Lam 2021-11-11 22:06:00 PST 
Created attachment 444045 [details]
proposed patch.
Comment 4 Mark Lam 2021-11-11 22:46:06 PST 
Created attachment 444049 [details]
proposed patch.
Comment 5 Yusuke Suzuki 2021-11-12 01:01:16 PST 
Comment on attachment 444049 [details]
proposed patch.

r=me
Comment 6 Mark Lam 2021-11-12 10:12:09 PST 
The mac-wk1 EWS failed tests is due to a known flaky crash on that test fast/dom/Geolocation/cached-position-iframe.html.  Hence, it's not related to this patch.
Comment 7 Mark Lam 2021-11-12 10:17:39 PST 
Thanks for the review.  Landed in r285730: <http://trac.webkit.org/r285730>.