| Summary: | Implement custom element definition's *disable shadow* flag | ||||||||
|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Alexey Shvayka <ashvayka> | ||||||
| Component: | DOM | Assignee: | Alexey Shvayka <ashvayka> | ||||||
| Status: | RESOLVED FIXED | ||||||||
| Severity: | Minor | CC: | cdumez, cmarcelo, esprehn+autocc, ews-watchlist, ggaren, hi, kangil.han, mkwst, webkit-bug-importer | ||||||
| Priority: | P2 | Keywords: | InRadar | ||||||
| Version: | WebKit Nightly Build | ||||||||
| Hardware: | All | ||||||||
| OS: | All | ||||||||
| Bug Depends on: | |||||||||
| Bug Blocks: | 197960 | ||||||||
| Attachments: |
|
||||||||
|
Description
Alexey Shvayka
2021-11-11 16:28:35 PST
Created attachment 444022 [details]
Patch
Created attachment 444037 [details]
Patch
Include HashSet.h
Comment on attachment 444037 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444037&action=review r=me > Source/WebCore/bindings/js/JSCustomElementInterface.cpp:53 > + , m_isShadowDisabled(false) I have a style preference for boolean conditions to be named in the affirmative, to avoid double negatives. So I would call this "isShadowEnabled", and initialize to true. But I guess the is the spec API name, so I'll ignore my preference here. > Source/WebCore/bindings/js/JSCustomElementInterface.h:111 > + bool m_isShadowDisabled : 1; Usually we don't do : 1 until there are more booleans to pack; but you mentioned that the follow-up patch will add them, so this is OK to me. Comment on attachment 444037 [details]
Patch
Thank you for live review Geoff!
Landing since EWS failures are unrelated.
Committed r285740 (244199@main): <https://commits.webkit.org/244199@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444037 [details]. |