Bug 233019

Summary: Add VM::writeBarrier() and VM::mutatorFence().
Product: WebKit Reporter: Mark Lam <mark.lam>
Component: JavaScriptCoreAssignee: Mark Lam <mark.lam>
Status: RESOLVED FIXED    
Severity: Normal CC: cdumez, ews-watchlist, keith_miller, msaboff, saam, tzagallo, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Bug Depends on:    
Bug Blocks: 232849    
Attachments:
Description Flags
proposed patch. saam: review+

Mark Lam
Reported 2021-11-11 15:26:09 PST
These are ALWAYS_INLINE functions that will forward the call to the Heap versions. Adding these allows us to make all the client code more terse, and also makes it easier to redirect the underlying writeBarrier implementation later for global GC work. Additionally, this will help make the global GC patch less of a mega patch and easier to review later. Also remove unused Heap::writeBarrierWithoutFence().
Attachments
proposed patch. (53.53 KB, patch)
2021-11-11 15:33 PST, Mark Lam 		saam: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-11 15:27:17 PST
<rdar://problem/85318693>
Mark Lam
Comment 2 2021-11-11 15:33:32 PST
Created attachment 444011 [details] proposed patch.
Mark Lam
Comment 3 2021-11-11 15:59:14 PST
Thanks for the review. Landed in r285687: <http://trac.webkit.org/r285687>.
Note You need to log in before you can comment on or make changes to this bug.