Summary: | REGRESSION: 26 InAppBrowserPrivacy API failures on iOS | ||||||
---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Truitt Savell <tsavell> | ||||
Component: | New Bugs | Assignee: | Chris Dumez <cdumez> | ||||
Status: | RESOLVED FIXED | ||||||
Severity: | Normal | CC: | achristensen, bfulgham, cdumez, ggaren, webkit-bot-watchers-bugzilla, webkit-bug-importer | ||||
Priority: | P2 | Keywords: | InRadar | ||||
Version: | WebKit Nightly Build | ||||||
Hardware: | Unspecified | ||||||
OS: | Unspecified | ||||||
Bug Depends on: | |||||||
Bug Blocks: | 232737 | ||||||
Attachments: |
|
Description
Truitt Savell
2021-11-11 14:21:29 PST
It looks like https://trac.webkit.org/changeset/285594/webkit could have possibly caused this. (In reply to Truitt Savell from comment #2) > It looks like https://trac.webkit.org/changeset/285594/webkit could have > possibly caused this. Oh? I can look but it seems a little surprising given that captive portal mode is disabled by default. (In reply to Chris Dumez from comment #3) > (In reply to Truitt Savell from comment #2) > > It looks like https://trac.webkit.org/changeset/285594/webkit could have > > possibly caused this. > > Oh? I can look but it seems a little surprising given that captive portal > mode is disabled by default. We noticed that ios-api EWS showed these as "new" failures on https://bugs.webkit.org/show_bug.cgi?id=232737, we're still confirming though. Created attachment 444006 [details]
Patch
Comment on attachment 444006 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444006&action=review r=me > Tools/TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:7629 > +// Also, some API tests rely on the browser entitlement not being present. We may have a way to address this, but should do so in a follow-up patch. Comment on attachment 444006 [details] Patch Clearing flags on attachment: 444006 Committed r285672 (244159@main): <https://commits.webkit.org/244159@main> All reviewed patches have been landed. Closing bug. |