Bug 233013

Summary: Disable MathML when in Captive Portal Mode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, calvaris, dbarton, esprehn+autocc, ews-watchlist, fred.wang, ggaren, kangil.han, kkinnunen, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233021
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Chris Dumez
Reported 2021-11-11 14:04:31 PST
Disable MathML when in Captive Portal Mode.
Attachments
Patch (8.19 KB, patch)
2021-11-11 14:26 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.84 KB, patch)
2021-11-12 07:23 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.81 KB, patch)
2021-11-12 07:51 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Patch (7.82 KB, patch)
2021-11-12 08:37 PST, Chris Dumez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (3) View All Add attachment proposed patch, testcase, etc.
Chris Dumez
Comment 1 2021-11-11 14:04:48 PST
<rdar://84567129>
Chris Dumez
Comment 2 2021-11-11 14:26:34 PST
Created attachment 444002 [details] Patch
Brent Fulgham
Comment 3 2021-11-11 16:33:28 PST
Comment on attachment 444002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444002&action=review r=me > Source/WebCore/ChangeLog:9 > + Add experimental feature flag for MathML and update implementation in WebCore to only support Nit: It's not really an experimental feature flag -- it's a runtime feature flag.
Chris Dumez
Comment 4 2021-11-11 16:34:00 PST
(In reply to Brent Fulgham from comment #3) > Comment on attachment 444002 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444002&action=review > > r=me > > > Source/WebCore/ChangeLog:9 > > + Add experimental feature flag for MathML and update implementation in WebCore to only support > > Nit: It's not really an experimental feature flag -- it's a runtime feature > flag. Indeed, force of habit. Will fix before landing.
Chris Dumez
Comment 5 2021-11-12 07:23:29 PST
Created attachment 444065 [details] Patch
Chris Dumez
Comment 6 2021-11-12 07:51:47 PST
Created attachment 444068 [details] Patch
EWS
Comment 7 2021-11-12 08:35:38 PST
Brent Fulham found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Brent Fulgham
Comment 8 2021-11-12 08:36:45 PST
(In reply to EWS from comment #7) > Brent Fulham found in :-|
Chris Dumez
Comment 9 2021-11-12 08:37:43 PST
Created attachment 444071 [details] Patch
Chris Dumez
Comment 10 2021-11-12 08:38:34 PST
(In reply to Brent Fulgham from comment #8) > (In reply to EWS from comment #7) > > Brent Fulham found in > > :-| Sorry I am a soccer fan :P
EWS
Comment 11 2021-11-12 10:29:21 PST
Committed r285731 (244190@main): <https://commits.webkit.org/244190@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444071 [details].
Note You need to log in before you can comment on or make changes to this bug.