Summary: | Disable MathML when in Captive Portal Mode | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Chris Dumez <cdumez> | ||||||||||
Component: | WebKit2 | Assignee: | Chris Dumez <cdumez> | ||||||||||
Status: | RESOLVED FIXED | ||||||||||||
Severity: | Normal | CC: | benjamin, bfulgham, calvaris, dbarton, esprehn+autocc, ews-watchlist, fred.wang, ggaren, kangil.han, kkinnunen, kondapallykalyan, webkit-bug-importer, youennf | ||||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||||
Version: | WebKit Nightly Build | ||||||||||||
Hardware: | Unspecified | ||||||||||||
OS: | Unspecified | ||||||||||||
See Also: | https://bugs.webkit.org/show_bug.cgi?id=233021 | ||||||||||||
Attachments: |
|
Description
Chris Dumez
2021-11-11 14:04:31 PST
Created attachment 444002 [details]
Patch
Comment on attachment 444002 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=444002&action=review r=me > Source/WebCore/ChangeLog:9 > + Add experimental feature flag for MathML and update implementation in WebCore to only support Nit: It's not really an experimental feature flag -- it's a runtime feature flag. (In reply to Brent Fulgham from comment #3) > Comment on attachment 444002 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=444002&action=review > > r=me > > > Source/WebCore/ChangeLog:9 > > + Add experimental feature flag for MathML and update implementation in WebCore to only support > > Nit: It's not really an experimental feature flag -- it's a runtime feature > flag. Indeed, force of habit. Will fix before landing. Created attachment 444065 [details]
Patch
Created attachment 444068 [details]
Patch
Brent Fulham found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json. /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). (In reply to EWS from comment #7) > Brent Fulham found in :-| Created attachment 444071 [details]
Patch
(In reply to Brent Fulgham from comment #8) > (In reply to EWS from comment #7) > > Brent Fulham found in > > :-| Sorry I am a soccer fan :P Committed r285731 (244190@main): <https://commits.webkit.org/244190@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 444071 [details]. |