Bug 233013

Summary: Disable MathML when in Captive Portal Mode
Product: WebKit Reporter: Chris Dumez <cdumez>
Component: WebKit2Assignee: Chris Dumez <cdumez>
Status: RESOLVED FIXED    
Severity: Normal CC: benjamin, bfulgham, calvaris, dbarton, esprehn+autocc, ews-watchlist, fred.wang, ggaren, kangil.han, kkinnunen, kondapallykalyan, webkit-bug-importer, youennf
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
See Also: https://bugs.webkit.org/show_bug.cgi?id=233021
Attachments:
Description Flags
Patch
none
Patch
none
Patch
none
Patch none

Description Chris Dumez 2021-11-11 14:04:31 PST
Disable MathML when in Captive Portal Mode.
Comment 1 Chris Dumez 2021-11-11 14:04:48 PST
<rdar://84567129>
Comment 2 Chris Dumez 2021-11-11 14:26:34 PST
Created attachment 444002 [details]
Patch
Comment 3 Brent Fulgham 2021-11-11 16:33:28 PST
Comment on attachment 444002 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=444002&action=review

r=me

> Source/WebCore/ChangeLog:9
> +        Add experimental feature flag for MathML and update implementation in WebCore to only support

Nit: It's not really an experimental feature flag -- it's a runtime feature flag.
Comment 4 Chris Dumez 2021-11-11 16:34:00 PST
(In reply to Brent Fulgham from comment #3)
> Comment on attachment 444002 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=444002&action=review
> 
> r=me
> 
> > Source/WebCore/ChangeLog:9
> > +        Add experimental feature flag for MathML and update implementation in WebCore to only support
> 
> Nit: It's not really an experimental feature flag -- it's a runtime feature
> flag.

Indeed, force of habit. Will fix before landing.
Comment 5 Chris Dumez 2021-11-12 07:23:29 PST
Created attachment 444065 [details]
Patch
Comment 6 Chris Dumez 2021-11-12 07:51:47 PST
Created attachment 444068 [details]
Patch
Comment 7 EWS 2021-11-12 08:35:38 PST
Brent Fulham found in /Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog does not appear to be a valid reviewer according to contributors.json.
/Volumes/Data/worker/Commit-Queue/build/Tools/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive).
Comment 8 Brent Fulgham 2021-11-12 08:36:45 PST
(In reply to EWS from comment #7)
> Brent Fulham found in

:-|
Comment 9 Chris Dumez 2021-11-12 08:37:43 PST
Created attachment 444071 [details]
Patch
Comment 10 Chris Dumez 2021-11-12 08:38:34 PST
(In reply to Brent Fulgham from comment #8)
> (In reply to EWS from comment #7)
> > Brent Fulham found in
> 
> :-|

Sorry I am a soccer fan :P
Comment 11 EWS 2021-11-12 10:29:21 PST
Committed r285731 (244190@main): <https://commits.webkit.org/244190@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 444071 [details].