| Summary: | [LFC][IFC] Reset InlineTextItem width on bidi split | ||||||
|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | zalan <zalan> | ||||
| Component: | Layout and Rendering | Assignee: | zalan <zalan> | ||||
| Status: | RESOLVED FIXED | ||||||
| Severity: | Normal | CC: | bfulgham, darin, simon.fraser, webkit-bug-importer, zalan | ||||
| Priority: | P2 | Keywords: | InRadar | ||||
| Version: | WebKit Nightly Build | ||||||
| Hardware: | Unspecified | ||||||
| OS: | Unspecified | ||||||
| Attachments: |
|
||||||
|
Description
zalan
2021-11-11 10:00:30 PST
Created attachment 443963 [details]
Patch
Comment on attachment 443963 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443963&action=review > Source/WebCore/ChangeLog:8 > + We remeasure the individual inline items right before line breaking. Was there a test that could have caught this mistake? (In reply to Darin Adler from comment #2) > Comment on attachment 443963 [details] > Patch > > View in context: > https://bugs.webkit.org/attachment.cgi?id=443963&action=review > > > Source/WebCore/ChangeLog:8 > > + We remeasure the individual inline items right before line breaking. > > Was there a test that could have caught this mistake? fast/text/international/bidi-layout-across-linebreak.html would have caught this, if this codepath was enabled (which it did at my trybot bug 229638). I am in the middle of enabling bidi content (including this codepath) for IFC (bug 232980) and going through the failures at https://ews-build.s3-us-west-2.amazonaws.com/macOS-Catalina-Release-WK1-Tests-EWS/r443898-20106/results.html (the trybot output) Committed r285642 (244143@main): <https://commits.webkit.org/244143@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443963 [details]. |