Bug 232998

Summary:

Non-unified build fixes, early November 2021 edition, bis

Product:

WebKit

Reporter:

Adrian Perez <aperez>

Component:

Tools / Tests

Assignee:

Adrian Perez <aperez>

Status:

RESOLVED FIXED

Severity:

Normal

CC:

cdumez, changseok, darin, dino, eric.carlson, esprehn+autocc, ews-watchlist, fmalita, glenn, gyuyoung.kim, hta, japhet, jer.noble, kangil.han, keith_miller, kondapallykalyan, mark.lam, mifenton, msaboff, pdr, philipj, saam, sabouhallawa, schenney, sergio, tommyw, tzagallo, webkit-bug-importer

Priority:

Keywords:

InRadar

Version:

WebKit Nightly Build

Hardware:

Unspecified

OS:

Unspecified

Attachments:

Description	Flags
Patch	none

Description Adrian Perez 2021-11-11 07:58:01 PST

👺️

Comment 1 Adrian Perez 2021-11-11 08:53:33 PST

Created attachment 443951 [details]
Patch

Comment 2 EWS 2021-11-11 13:29:07 PST

Committed r285654 (244152@main): <https://commits.webkit.org/244152@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443951 [details].

Comment 3 Radar WebKit Bug Importer 2021-11-11 13:30:20 PST

<rdar://problem/85313167>

Comment 4 Darin Adler 2021-11-11 13:32:31 PST

Comment on attachment 443951 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443951&action=review

> Source/WebCore/ChangeLog:35
> +        * platform/gamepad/GamepadConstants.h: Add missing WTF:: namespace prefix to uses of
> +        WTF::String.

This was an incorrect change. Could you tell me more about why the compile failed without it?

> Source/WebCore/platform/gamepad/GamepadConstants.h:67
> -const String& standardGamepadMappingString();
> +const WTF::String& standardGamepadMappingString();
>  #if ENABLE(WEBXR)
> -const String& xrStandardGamepadMappingString();
> +const WTF::String& xrStandardGamepadMappingString();
>  #endif

This is not the correct idiom. Instead this header should include <wtf/Forward.h> and remove the declaration of the String class above.

Comment 5 Adrian Perez 2021-11-12 06:25:36 PST

(In reply to Darin Adler from comment #4)
> Comment on attachment 443951 [details]
> Patch
> 
> View in context:
> https://bugs.webkit.org/attachment.cgi?id=443951&action=review
> 
> > Source/WebCore/ChangeLog:35
> > +        * platform/gamepad/GamepadConstants.h: Add missing WTF:: namespace prefix to uses of
> > +        WTF::String.
> 
> This was an incorrect change. Could you tell me more about why the compile
> failed without it?
> 
> > Source/WebCore/platform/gamepad/GamepadConstants.h:67
> > -const String& standardGamepadMappingString();
> > +const WTF::String& standardGamepadMappingString();
> >  #if ENABLE(WEBXR)
> > -const String& xrStandardGamepadMappingString();
> > +const WTF::String& xrStandardGamepadMappingString();
> >  #endif
> 
> This is not the correct idiom. Instead this header should include
> <wtf/Forward.h> and remove the declaration of the String class above.

Fixed in r285715 — thanks for commenting on this :)