Bug 232983

Summary: AX: Implement AXCoreObject::value for AXIsolatedObject
Product: WebKit Reporter: Tyler Wilcock <tyler_w>
Component: AccessibilityAssignee: Tyler Wilcock <tyler_w>
Status: RESOLVED FIXED    
Severity: Normal CC: aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
none
Patch none

Tyler Wilcock
Reported 2021-11-10 21:04:59 PST
The current implementation returns nothing. AXIsolatedObject.h AXValue value() override { return { }; }
Attachments
Patch (8.07 KB, patch)
2021-11-10 21:17 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.06 KB, patch)
2021-11-10 21:52 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Patch (8.25 KB, patch)
2021-11-10 22:50 PST, Tyler Wilcock 		no flags
DetailsFormatted DiffDiff
Show Obsolete (2) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-10 21:05:15 PST
<rdar://problem/85283345>
Tyler Wilcock
Comment 2 2021-11-10 21:17:12 PST
Created attachment 443904 [details] Patch
chris fleizach
Comment 3 2021-11-10 21:29:46 PST
Comment on attachment 443904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443904&action=review > Source/WebCore/accessibility/AccessibilityObjectInterface.h:1146 > + virtual AXValue value() does this still need to be virtual now?
Tyler Wilcock
Comment 4 2021-11-10 21:52:15 PST
Created attachment 443908 [details] Patch
chris fleizach
Comment 5 2021-11-10 22:19:12 PST
Comment on attachment 443908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443908&action=review > Source/WebCore/accessibility/AccessibilityObjectInterface.h:1146 > + AXValue value() it looks like when we have code to inline, the preference is to put it a little farther down the file near things like inline void AXCoreObject::detachWrapper(AccessibilityDetachmentType detachmentType) {
Tyler Wilcock
Comment 6 2021-11-10 22:50:11 PST
Created attachment 443912 [details] Patch
EWS
Comment 7 2021-11-11 07:57:21 PST
Committed r285632 (244133@main): <https://commits.webkit.org/244133@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443912 [details].
Note You need to log in before you can comment on or make changes to this bug.