| Summary: | AX: Implement AXCoreObject::value for AXIsolatedObject | ||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|
| Product: | WebKit | Reporter: | Tyler Wilcock <tyler_w> | ||||||||
| Component: | Accessibility | Assignee: | Tyler Wilcock <tyler_w> | ||||||||
| Status: | RESOLVED FIXED | ||||||||||
| Severity: | Normal | CC: | aboxhall, andresg_22, apinheiro, cfleizach, dmazzoni, ews-watchlist, jcraig, jdiggs, samuel_white, webkit-bug-importer | ||||||||
| Priority: | P2 | Keywords: | InRadar | ||||||||
| Version: | WebKit Nightly Build | ||||||||||
| Hardware: | Unspecified | ||||||||||
| OS: | Unspecified | ||||||||||
| Attachments: |
|
||||||||||
Created attachment 443904 [details]
Patch
Comment on attachment 443904 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443904&action=review > Source/WebCore/accessibility/AccessibilityObjectInterface.h:1146 > + virtual AXValue value() does this still need to be virtual now? Created attachment 443908 [details]
Patch
Comment on attachment 443908 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443908&action=review > Source/WebCore/accessibility/AccessibilityObjectInterface.h:1146 > + AXValue value() it looks like when we have code to inline, the preference is to put it a little farther down the file near things like inline void AXCoreObject::detachWrapper(AccessibilityDetachmentType detachmentType) { Created attachment 443912 [details]
Patch
Committed r285632 (244133@main): <https://commits.webkit.org/244133@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443912 [details]. |
The current implementation returns nothing. AXIsolatedObject.h AXValue value() override { return { }; }