Bug 232965

Summary: [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

pascoe@apple.com
Reported 2021-11-10 13:35:28 PST
Whenever generating assertions via ASC ui, the client data json returned is not the same client data json that is used for hashing purposes. This change modifies the clientDataJson SPI to use the same method as AuthenticatorCoordinator.
Attachments
Patch (14.02 KB, patch)
2021-11-10 14:06 PST, pascoe@apple.com
ews-feeder: commit-queue-
Patch (14.26 KB, patch)
2021-11-10 15:05 PST, pascoe@apple.com
no flags
Patch (14.27 KB, patch)
2021-11-10 15:06 PST, pascoe@apple.com
no flags
Radar WebKit Bug Importer
Comment 1 2021-11-10 13:35:45 PST
Radar WebKit Bug Importer
Comment 2 2021-11-10 13:36:59 PST
pascoe@apple.com
Comment 3 2021-11-10 14:06:31 PST
pascoe@apple.com
Comment 4 2021-11-10 14:13:49 PST
In the longer term, we should find a way to avoid generating ClientDataJson in two places.
pascoe@apple.com
Comment 5 2021-11-10 15:05:04 PST
pascoe@apple.com
Comment 6 2021-11-10 15:06:42 PST
Brent Fulgham
Comment 7 2021-11-10 15:24:31 PST
Comment on attachment 443871 [details] Patch Looks good! r=me
EWS
Comment 8 2021-11-10 18:52:08 PST
Committed r285617 (244118@main): <https://commits.webkit.org/244118@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443871 [details].
Note You need to log in before you can comment on or make changes to this bug.