Bug 232965

Summary: [WebAuthn] Unify _WKWebAuthenticationPanel SPI and AuthenticatorCoordinator's ClientDataJson generation
Product: WebKit Reporter: pascoe <pascoe>
Component: WebKit Misc.Assignee: pascoe <pascoe>
Status: RESOLVED FIXED    
Severity: Normal CC: bfulgham, ews-watchlist, jiewen_tan, webkit-bug-importer
Priority: P1 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
ews-feeder: commit-queue-
Patch
none
Patch none

Description pascoe@apple.com 2021-11-10 13:35:28 PST 
Whenever generating assertions via ASC ui, the client data json returned is not the same client data json that is used for hashing purposes. This change modifies the clientDataJson SPI to use the same method as AuthenticatorCoordinator.
Comment 1 Radar WebKit Bug Importer 2021-11-10 13:35:45 PST 
<rdar://problem/85268216>
Comment 2 Radar WebKit Bug Importer 2021-11-10 13:36:59 PST 
<rdar://problem/85268259>
Comment 3 pascoe@apple.com 2021-11-10 14:06:31 PST 
Created attachment 443862 [details]
Patch
Comment 4 pascoe@apple.com 2021-11-10 14:13:49 PST 
In the longer term, we should find a way to avoid generating ClientDataJson in two places.
Comment 5 pascoe@apple.com 2021-11-10 15:05:04 PST 
Created attachment 443870 [details]
Patch
Comment 6 pascoe@apple.com 2021-11-10 15:06:42 PST 
Created attachment 443871 [details]
Patch
Comment 7 Brent Fulgham 2021-11-10 15:24:31 PST 
Comment on attachment 443871 [details]
Patch

Looks good! r=me
Comment 8 EWS 2021-11-10 18:52:08 PST 
Committed r285617 (244118@main): <https://commits.webkit.org/244118@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443871 [details].