Bug 232961

Summary: WKSystemPreviewView should be called WKUSDPreviewView
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebKit Misc.Assignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
sam: review+, ews-feeder: commit-queue-
EWS test none

Dean Jackson
Reported 2021-11-10 12:19:52 PST
WKSystemPreviewView is a uninformative name. WKUSDPreviewView is more accurate. While here, change the WebCore code that looks for SystemPreview MIME types to reflect it is looking for USD.
Attachments
Patch (32.34 KB, patch)
2021-11-10 12:28 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Patch (32.34 KB, patch)
2021-11-10 12:56 PST, Dean Jackson 		sam: review+
ews-feeder: commit-queue-
DetailsFormatted DiffDiff
EWS test (32.71 KB, patch)
2021-11-11 08:26 PST, Dean Jackson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Radar WebKit Bug Importer
Comment 1 2021-11-10 12:20:19 PST
<rdar://problem/85265415>
Dean Jackson
Comment 2 2021-11-10 12:28:19 PST
Created attachment 443847 [details] Patch
Dean Jackson
Comment 3 2021-11-10 12:56:24 PST
Created attachment 443855 [details] Patch
Sam Weinig
Comment 4 2021-11-10 15:01:51 PST
Comment on attachment 443855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review r=me, but please make sure it builds. > Source/WebKit/SourcesCocoa.txt:509 > +UIProcess/ios/WKUSDPreviewView.mm This needs to be sorted. > Source/WebKit/UIProcess/SystemPreviewController.cpp:41 > bool SystemPreviewController::canPreview(const String& mimeType) const Should this class get renamed in the future as well?
Dean Jackson
Comment 5 2021-11-11 08:25:06 PST
Comment on attachment 443855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review >> Source/WebKit/SourcesCocoa.txt:509 >> +UIProcess/ios/WKUSDPreviewView.mm > > This needs to be sorted. Nice catch. >> Source/WebKit/UIProcess/SystemPreviewController.cpp:41 >> bool SystemPreviewController::canPreview(const String& mimeType) const > > Should this class get renamed in the future as well? Yes, that's coming soon.
Dean Jackson
Comment 6 2021-11-11 08:26:58 PST
Created attachment 443949 [details] EWS test
EWS
Comment 7 2021-11-11 09:22:35 PST
Committed r285635 (244136@main): <https://commits.webkit.org/244136@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443949 [details].
Note You need to log in before you can comment on or make changes to this bug.