Summary: | WKSystemPreviewView should be called WKUSDPreviewView | ||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|
Product: | WebKit | Reporter: | Dean Jackson <dino> | ||||||||
Component: | WebKit Misc. | Assignee: | Dean Jackson <dino> | ||||||||
Status: | RESOLVED FIXED | ||||||||||
Severity: | Normal | CC: | sam, webkit-bug-importer | ||||||||
Priority: | P2 | Keywords: | InRadar | ||||||||
Version: | WebKit Nightly Build | ||||||||||
Hardware: | Unspecified | ||||||||||
OS: | Unspecified | ||||||||||
Attachments: |
|
Description
Dean Jackson
2021-11-10 12:19:52 PST
Created attachment 443847 [details]
Patch
Created attachment 443855 [details]
Patch
Comment on attachment 443855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review r=me, but please make sure it builds. > Source/WebKit/SourcesCocoa.txt:509 > +UIProcess/ios/WKUSDPreviewView.mm This needs to be sorted. > Source/WebKit/UIProcess/SystemPreviewController.cpp:41 > bool SystemPreviewController::canPreview(const String& mimeType) const Should this class get renamed in the future as well? Comment on attachment 443855 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review >> Source/WebKit/SourcesCocoa.txt:509 >> +UIProcess/ios/WKUSDPreviewView.mm > > This needs to be sorted. Nice catch. >> Source/WebKit/UIProcess/SystemPreviewController.cpp:41 >> bool SystemPreviewController::canPreview(const String& mimeType) const > > Should this class get renamed in the future as well? Yes, that's coming soon. Created attachment 443949 [details]
EWS test
Committed r285635 (244136@main): <https://commits.webkit.org/244136@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 443949 [details]. |