Bug 232961

Summary: WKSystemPreviewView should be called WKUSDPreviewView
Product: WebKit Reporter: Dean Jackson <dino>
Component: WebKit Misc.Assignee: Dean Jackson <dino>
Status: RESOLVED FIXED    
Severity: Normal CC: sam, webkit-bug-importer
Priority: P2 Keywords: InRadar
Version: WebKit Nightly Build   
Hardware: Unspecified   
OS: Unspecified   
Attachments:
Description Flags
Patch
none
Patch
sam: review+, ews-feeder: commit-queue-
EWS test none

Description Dean Jackson 2021-11-10 12:19:52 PST
WKSystemPreviewView is a uninformative name. WKUSDPreviewView is more accurate.

While here, change the WebCore code that looks for SystemPreview MIME types to reflect it is looking for USD.
Comment 1 Radar WebKit Bug Importer 2021-11-10 12:20:19 PST
<rdar://problem/85265415>
Comment 2 Dean Jackson 2021-11-10 12:28:19 PST
Created attachment 443847 [details]
Patch
Comment 3 Dean Jackson 2021-11-10 12:56:24 PST
Created attachment 443855 [details]
Patch
Comment 4 Sam Weinig 2021-11-10 15:01:51 PST
Comment on attachment 443855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review

r=me, but please make sure it builds.

> Source/WebKit/SourcesCocoa.txt:509
> +UIProcess/ios/WKUSDPreviewView.mm

This needs to be sorted.

> Source/WebKit/UIProcess/SystemPreviewController.cpp:41
>  bool SystemPreviewController::canPreview(const String& mimeType) const

Should this class get renamed in the future as well?
Comment 5 Dean Jackson 2021-11-11 08:25:06 PST
Comment on attachment 443855 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=443855&action=review

>> Source/WebKit/SourcesCocoa.txt:509
>> +UIProcess/ios/WKUSDPreviewView.mm
> 
> This needs to be sorted.

Nice catch.

>> Source/WebKit/UIProcess/SystemPreviewController.cpp:41
>>  bool SystemPreviewController::canPreview(const String& mimeType) const
> 
> Should this class get renamed in the future as well?

Yes, that's coming soon.
Comment 6 Dean Jackson 2021-11-11 08:26:58 PST
Created attachment 443949 [details]
EWS test
Comment 7 EWS 2021-11-11 09:22:35 PST
Committed r285635 (244136@main): <https://commits.webkit.org/244136@main>

All reviewed patches have been landed. Closing bug and clearing flags on attachment 443949 [details].